Re: [patch] dpaa_eth: small leak on error

[David Miller]

From: Dan Carpenter 
Date: Thu, 16 Feb 2017 12:56:10 +0300

> This should be >= instead of > here.  It means that we don't increment
> the free count enough so it becomes off by one.
> 
> Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
> Signed-off-by: Dan Carpenter 
> ---
> Applies to -net tree.

Applied, thanks Dan.

[patch] dpaa_eth: small leak on error

[Dan Carpenter]

This should be >= instead of > here.  It means that we don't increment
the free count enough so it becomes off by one.

Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
Signed-off-by: Dan Carpenter 
---
Applies to -net tree.

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c 
b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index 25a14a3fe784..bc5a3347fd4a 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -1666,7 +1666,7 @@ static struct sk_buff *sg_fd_to_skb(const struct 
dpaa_priv *priv,
 
 free_buffers:
/* compensate sw bpool counter changes */
-   for (i--; i > 0; i--) {
+   for (i--; i >= 0; i--) {
dpaa_bp = dpaa_bpid2pool(sgt[i].bpid);
if (dpaa_bp) {
count_ptr = this_cpu_ptr(dpaa_bp->percpu_count);