[PATCH net-next 11/11] nfp: report more info when reconfiguration fails

2018-11-27 Thread Jakub Kicinski
FW reconfiguration timeouts are a common indicator of FW trouble. To make debugging easier print requested update and control word when reconfiguration fails. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 2 ++

Re: [PATCH net-next 0/2] bnx2x: Popoulate firmware versions in driver info query.

2018-11-27 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Mon, 26 Nov 2018 22:25:55 -0800 > From: Sudarsana Reddy Kalluru > > The patch series populates MBI and storm firware versions in the ethtool > driver info query. > > Please consider applying it to 'net-next' tree. Series applied.

[PATCH net-next 0/2] bnx2x: Popoulate firmware versions in driver info query.

2018-11-26 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The patch series populates MBI and storm firware versions in the ethtool driver info query. Please consider applying it to 'net-next' tree. Sudarsana Reddy Kalluru (2): bnx2x: Add MBI version to ethtool driver query output. bnx2x: Add storm FW version

Re: [PATCH bpf-next 0/2] bpf: support proper non-jit func info

2018-11-26 Thread Alexei Starovoitov
On Sat, Nov 24, 2018 at 11:20:43PM -0800, Yonghong Song wrote: > Commit 838e96904ff3 ("bpf: Introduce bpf_func_info") > added bpf func info support. The userspace is able > to get better ksym's for bpf programs with jit, and > is able to print out func prototypes. > &

Re: [PATCH bpf-next 1/2] bpf: btf: support proper non-jit func info

2018-11-26 Thread Martin Lau
On Sat, Nov 24, 2018 at 11:20:44PM -0800, Yonghong Song wrote: > Commit 838e96904ff3 ("bpf: Introduce bpf_func_info") > added bpf func info support. The userspace is able > to get better ksym's for bpf programs with jit, and > is able to print out func prototypes. > &

[PATCH bpf-next 0/2] bpf: support proper non-jit func info

2018-11-24 Thread Yonghong Song
Commit 838e96904ff3 ("bpf: Introduce bpf_func_info") added bpf func info support. The userspace is able to get better ksym's for bpf programs with jit, and is able to print out func prototypes. For a program containing func-to-func calls, the existing implementation returns user specif

[PATCH bpf-next 1/2] bpf: btf: support proper non-jit func info

2018-11-24 Thread Yonghong Song
Commit 838e96904ff3 ("bpf: Introduce bpf_func_info") added bpf func info support. The userspace is able to get better ksym's for bpf programs with jit, and is able to print out func prototypes. For a program containing func-to-func calls, the existing implementation returns user specif

Re: [PATCH v5 bpf-next 00/13] bpf: Add btf func info support

2018-11-20 Thread Alexei Starovoitov
file and is primarily > > used for map pretty print. > > pahole is used to convert dwarf to BTF for ELF files. > > > > This patch added func info support to the kernel so we can > > get better ksym's for bpf function calls. Basically, > > function call types

Re: [PATCH v5 bpf-next 00/13] bpf: Add btf func info support

2018-11-20 Thread Edward Cree
vert dwarf to BTF for ELF files. > > This patch added func info support to the kernel so we can > get better ksym's for bpf function calls. Basically, > function call types are passed to kernel and the kernel > extract function names from these types in order to contruct ksym > for t

[PATCH v5 bpf-next 00/13] bpf: Add btf func info support

2018-11-19 Thread Martin KaFai Lau
The BTF support was added to kernel by Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)"), which introduced .BTF section into ELF file and is primarily used for map pretty print. pahole is used to convert dwarf to BTF for ELF files. This patch added func info support to

[PATCH v5 bpf-next 12/13] tools/bpf: enhance test_btf file testing to test func info

2018-11-19 Thread Martin KaFai Lau
signed int test_num) { const struct btf_file_test *test = _tests[test_num - 1]; + const char *expected_fnames[] = {"_dummy_tracepoint", +"test_long_fname_1", +"test_long_fname_2&q

[PATCH v5 bpf-next 08/13] tools/bpf: extends test_btf to test load/retrieve func_type info

2018-11-19 Thread Martin KaFai Lau
From: Yonghong Song A two function bpf program is loaded with btf and func_info. After successful prog load, the bpf_get_info syscall is called to retrieve prog info to ensure the types returned from the kernel matches the types passed to the kernel from the user space. Several negative tests

Re: [PATCH bpf-next 0/2] bpf: offer maximum packet offset info

2018-11-09 Thread Daniel Borkmann
On 11/08/2018 10:08 AM, Jiong Wang wrote: > The maximum packet offset accessed by one BPF program is useful > information. > > Because sometimes there could be packet split and it is possible for some > reasons (for example performance) we want to reject the BPF program if the > maximum packet

[PATCH net-next 4/7] nfp: abm: provide more precise info about offload parameter validation

2018-11-08 Thread Jakub Kicinski
Improve log messages printed when RED can't be offloaded because of Qdisc parameters. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley Reviewed-by: Quentin Monnet --- .../net/ethernet/netronome/nfp/abm/qdisc.c| 24 --- 1 file changed, 21 insertions(+), 3 deletions(-)

[PATCH bpf-next v4 12/13] tools/bpf: enhance test_btf file testing to test func info

2018-11-08 Thread Yonghong Song
test *test = _tests[test_num - 1]; + const char *expected_fnames[] = {"_dummy_tracepoint", +"test_long_fname_1", +"test_long_fname_2"}; + struct bpf_prog_info info = {}; struc

[PATCH bpf-next v4 08/13] tools/bpf: extends test_btf to test load/retrieve func_type info

2018-11-08 Thread Yonghong Song
A two function bpf program is loaded with btf and func_info. After successful prog load, the bpf_get_info syscall is called to retrieve prog info to ensure the types returned from the kernel matches the types passed to the kernel from the user space. Several negative tests are also added to test

[PATCH bpf-next v4 00/13] bpf: add btf func info support

2018-11-08 Thread Yonghong Song
The BTF support was added to kernel by Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)"), which introduced .BTF section into ELF file and is primarily used for map pretty print. pahole is used to convert dwarf to BTF for ELF files. This patch added func info support to

[PATCH bpf-next 0/2] bpf: offer maximum packet offset info

2018-11-08 Thread Jiong Wang
The maximum packet offset accessed by one BPF program is useful information. Because sometimes there could be packet split and it is possible for some reasons (for example performance) we want to reject the BPF program if the maximum packet size would trigger such split. Normally, MTU value is

Re: [PATCH ghak90 (was ghak32) V4 03/10] audit: log container info of syscalls

2018-10-25 Thread Richard Guy Briggs
On 2018-10-19 19:16, Paul Moore wrote: > > > > > > > > On Sun, Aug 5, 2018 at 4:32 AM Richard Guy Briggs > > > > > > > > wrote: > > > > > > ... > > > > > > > > > > > > +

[PATCH v2 12/17] octeontx2-af: Add LMAC channel info to NIXLF_ALLOC response

2018-10-22 Thread sunil . kovvuri
From: Stanislaw Kardach Add LMAC channel info like Rx/Tx channel base and count to NIXLF_ALLOC mailbox message response. This info is used by NIXLF attached RVU PF/VF to configure SQ's default channel, TL3_TL2_LINKX_CFG and to install MCAM rules in NPC based on matching ingress channel number

[PATCH 12/17] octeontx2-af: Add LMAC channel info to NIXLF_ALLOC response

2018-10-19 Thread sunil . kovvuri
From: Stanislaw Kardach Add LMAC channel info like Rx/Tx channel base and count to NIXLF_ALLOC mailbox message response. This info is used by NIXLF attached RVU PF/VF to configure SQ's default channel, TL3_TL2_LINKX_CFG and to install MCAM rules in NPC based on matching ingress channel number

Re: [PATCH net-next] MAINTAINERS: Update contact info for VRF entry

2018-10-18 Thread David Miller
From: David Ahern Date: Thu, 18 Oct 2018 13:15:49 -0600 > From: David Ahern > > Update Shrijeet's email address for the VRF entry. > > Signed-off-by: David Ahern Applied.

[PATCH net-next] MAINTAINERS: Update contact info for VRF entry

2018-10-18 Thread David Ahern
From: David Ahern Update Shrijeet's email address for the VRF entry. Signed-off-by: David Ahern --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7f1399ac028e..144cd0ca41ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15745,7

Re: [PATCH bpf-next v3 00/13] bpf: add btf func info support

2018-10-17 Thread Alexei Starovoitov
On Wed, Oct 17, 2018 at 04:30:22PM -0700, Yonghong Song wrote: > > This patch added func info support to the kernel so we can > get better ksym's for bpf function calls. Basically, > pairs of bpf function calls and their corresponding types > are passed to the kernel. Extracting

[PATCH bpf-next v3 12/13] tools/bpf: enhance test_btf file testing to test func info

2018-10-17 Thread Yonghong Song
test *test = _tests[test_num - 1]; + const char *expected_fnames[] = {"_dummy_tracepoint", +"test_long_fname_1", +"test_long_fname_2"}; + __u32 func_lens[10], func_types[10], inf

[PATCH bpf-next v3 08/13] tools/bpf: extends test_btf to test load/retrieve func_type info

2018-10-17 Thread Yonghong Song
A two function bpf program is loaded with btf and func_info. After successful prog load, the bpf_get_info syscall is called to retrieve prog info to ensure the types returned from the kernel matches the types passed to the kernel from the user space. Several negative tests are also added to test

[PATCH bpf-next v3 00/13] bpf: add btf func info support

2018-10-17 Thread Yonghong Song
The BTF support was added to kernel by Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)"), which introduced .BTF section into ELF file and is primarily used for map pretty print. pahole is used to convert dwarf to BTF for ELF files. This patch added func info support to

Re: [PATCH bpf-next v2 00/13] bpf: add btf func info support

2018-10-17 Thread Yonghong Song
On 10/17/18 4:02 AM, Edward Cree wrote: > I think the BTF work needs to be better documented; at the moment the only way >  to determine how BTF sections are structured is to read through the headers, >  and cross-reference with the DWARF spec to guess at the semantics of various >  fields. 

Re: [PATCH bpf-next v2 00/13] bpf: add btf func info support

2018-10-17 Thread Edward Cree
I think the BTF work needs to be better documented; at the moment the only way  to determine how BTF sections are structured is to read through the headers,  and cross-reference with the DWARF spec to guess at the semantics of various  fields.  I've been working on adding BTF support to ebpf_asm,

[PATCH bpf-next v2 12/13] tools/bpf: enhance test_btf file testing to test func info

2018-10-17 Thread Yonghong Song
[] = {"_dummy_tracepoint", +"test_long_fname_1", +"test_long_fname_2"}; + __u32 func_lens[10], func_types[10], info_len; + struct bpf_prog_info info = {}; struct bpf_object *obj = NU

[PATCH bpf-next v2 00/13] bpf: add btf func info support

2018-10-17 Thread Yonghong Song
The BTF support was added to kernel by Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)"), which introduced .BTF section into ELF file and is primarily used for map pretty print. pahole is used to convert dwarf to BTF for ELF files. This patch added func info support to

[PATCH bpf-next v2 08/13] tools/bpf: extends test_btf to test load/retrieve func_type info

2018-10-17 Thread Yonghong Song
A two function bpf program is loaded with btf and func_info. After successful prog load, the bpf_get_info syscall is called to retrieve prog info to ensure the types returned from the kernel matches the types passed to the kernel from the user space. Several negative tests are also added to test

Re: [PATCH bpf-next 00/13] bpf: add btf func info support

2018-10-16 Thread Yonghong Song
F file and is primarily >> used for map pretty print. >> pahole is used to convert dwarf to BTF for ELF files. >> >> The next step would be add func type info and debug line info >> into BTF. For debug line info, it is desirable to encode >> source code directly

Re: [PATCH bpf-next 00/13] bpf: add btf func info support

2018-10-16 Thread Alexei Starovoitov
is used to convert dwarf to BTF for ELF files. > > The next step would be add func type info and debug line info > into BTF. For debug line info, it is desirable to encode > source code directly in the BTF to ease deployment and > introspection. it's kinda confusing that cove

[PATCH bpf-next 12/13] tools/bpf: enhance test_btf file testing to test func info

2018-10-12 Thread Yonghong Song
[] = {"_dummy_tracepoint", +"test_long_fname_1", +"test_long_fname_2"}; + __u32 func_lens[10], func_types[10], info_len; + struct bpf_prog_info info = {}; struct bpf_object *obj = NU

[PATCH bpf-next 08/13] tools/bpf: extends test_btf to test load/retrieve func_type info

2018-10-12 Thread Yonghong Song
A two function bpf program is loaded with btf and func_info. After successful prog load, the bpf_get_info syscall is called to retrieve prog info to ensure the types returned from the kernel matches the types passed to the kernel from the user space. Several negative tests are also added to test

[PATCH bpf-next 00/13] bpf: add btf func info support

2018-10-12 Thread Yonghong Song
The BTF support was added to kernel by Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)"), which introduced .BTF section into ELF file and is primarily used for map pretty print. pahole is used to convert dwarf to BTF for ELF files. The next step would be add func

[PATCH V2 net-next 02/12] net: ena: complete host info to match latest ENA spec

2018-10-11 Thread akiyano
From: Arthur Kiyanovski Add new fields and definitions to host info and fill them according to the latest ENA spec version. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 31 ++- drivers/net/ethernet/amazon/ena/ena_com.c

[PATCH v9 03/15] octeontx2-af: Gather RVU blocks HW info

2018-10-10 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF

[PATCH V1 net-next 02/12] net: ena: complete host info to match latest ENA spec

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Add new fields and definitions to host info and fill them according to the latest ENA spec version. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 31 ++- drivers/net/ethernet/amazon/ena/ena_com.c

Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

2018-10-08 Thread Mike Rapoport
On Mon, Oct 08, 2018 at 12:15:54PM -0600, David Ahern wrote: > On 10/8/18 6:06 AM, Mike Rapoport wrote: > > The fib6_info_alloc() function allocates percpu memory to hold per CPU > > pointers to rt6_info, but this memory is never freed. Fix it. > > > > Fixes: a64efe142f5e ("net/ipv6: introduce

[PATCH net] net/ipv6: stop leaking percpu memory in fib6 info

2018-10-08 Thread Mike Rapoport
The fib6_info_alloc() function allocates percpu memory to hold per CPU pointers to rt6_info, but this memory is never freed. Fix it. Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers") Signed-off-by: Mike Rapoport Reviewed-by: David Ahern --- net/ipv6/ip6_fib.c | 2 ++ 1

Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

2018-10-08 Thread David Ahern
On 10/8/18 6:06 AM, Mike Rapoport wrote: > The fib6_info_alloc() function allocates percpu memory to hold per CPU > pointers to rt6_info, but this memory is never freed. Fix it. > > Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers") > > Signed-off-by: Mike Rapoport > Cc:

Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

2018-10-08 Thread David Miller
From: Mike Rapoport Date: Mon, 8 Oct 2018 15:06:03 +0300 > The fib6_info_alloc() function allocates percpu memory to hold per CPU > pointers to rt6_info, but this memory is never freed. Fix it. > > Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers") > Please do not put

[PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

2018-10-08 Thread Mike Rapoport
The fib6_info_alloc() function allocates percpu memory to hold per CPU pointers to rt6_info, but this memory is never freed. Fix it. Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers") Signed-off-by: Mike Rapoport Cc: sta...@vger.kernel.org --- net/ipv6/ip6_fib.c | 2 ++ 1

[PATCH v8 03/15] octeontx2-af: Gather RVU blocks HW info

2018-10-07 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF

[PATCH bpf-next 01/12] bpf: add verifier callback to get stack usage info for offloaded progs

2018-10-07 Thread Quentin Monnet
In preparation for BPF-to-BPF calls in offloaded programs, add a new function attribute to the struct bpf_prog_offload_ops so that drivers supporting eBPF offload can hook at the end of program verification, and potentially extract information collected by the verifier. Implement a minimal

[PATCH v7 03/15] octeontx2-af: Gather RVU blocks HW info

2018-10-06 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF

[PATCH v6 03/15] octeontx2-af: Gather RVU blocks HW info

2018-10-04 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF

[PATCH v5 03/15] octeontx2-af: Gather RVU blocks HW info

2018-10-01 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF

[PATCH 03/15] octeontx2-af: Gather RVU blocks HW info

2018-09-28 Thread sunil . kovvuri
From: Sunil Goutham This patch gathers NPA/NIX/SSO/SSOW/TIM/CPT RVU blocks's HW info like number of LFs. Important register offsets saved for later use to avoid code duplication for each block. A bitmap is allocated for each of the blocks which later on will be used to allocate a LF for a RVU PF

Re: [PATCH iproute2] vxlan: show correct ttl inherit info

2018-09-27 Thread Phil Sutter
the value to 1 and when displaying explicitly check whether the > > attribute is there *and* non-zero. OK, looks like Geneve driver always > > exports IFLA_GENEVE_TTL_INHERIT. Oddly, I can't find where VXLAN driver > > in kernel does export the IFLA_VXLAN_TTL_INHERIT attribute.

Re: [PATCH iproute2] vxlan: show correct ttl inherit info

2018-09-27 Thread Hangbin Liu
NHERIT. Oddly, I can't find where VXLAN driver > in kernel does export the IFLA_VXLAN_TTL_INHERIT attribute. Am I missing > something? Hi Phil, The vxlan ttl inherit exportation is just fixed by net commit 8fd78069874 ("vxlan: fill ttl inherit info") yesterday. > Do you know why hand

Re: [PATCH iproute2] vxlan: show correct ttl inherit info

2018-09-27 Thread Phil Sutter
Hi Hangbin, On Thu, Sep 27, 2018 at 03:28:36PM +0800, Hangbin Liu wrote: > We should only show ttl inherit when IFLA_VXLAN_TTL_INHERIT supplied. > Otherwise show the ttl number, or auto when it is 0. > > Signed-off-by: Hangbin Liu > --- > ip/iplink_vxlan.c | 16 ++-- > 1 file

[PATCH iproute2] vxlan: show correct ttl inherit info

2018-09-27 Thread Hangbin Liu
We should only show ttl inherit when IFLA_VXLAN_TTL_INHERIT supplied. Otherwise show the ttl number, or auto when it is 0. Signed-off-by: Hangbin Liu --- ip/iplink_vxlan.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c

Re: [PATCH net] vxlan: fill ttl inherit info

2018-09-26 Thread David Miller
From: Hangbin Liu Date: Wed, 26 Sep 2018 10:35:42 +0800 > When add vxlan ttl inherit support, I forgot to fill it when dump > vlxan info. Fix it now. > > Fixes: 72f6d71e491e6 ("vxlan: add ttl inherit support") > Signed-off-by: Hangbin Liu Applied and queued up for -stable.

[PATCH net] vxlan: fill ttl inherit info

2018-09-25 Thread Hangbin Liu
When add vxlan ttl inherit support, I forgot to fill it when dump vlxan info. Fix it now. Fixes: 72f6d71e491e6 ("vxlan: add ttl inherit support") Signed-off-by: Hangbin Liu --- drivers/net/vxlan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/n

Re: [PATCH iproute2 v2] tc/mqprio: Print extra info on invalid args.

2018-09-10 Thread Stephen Hemminger
On Thu, 6 Sep 2018 14:01:17 -0700 Caleb Raitto wrote: > From: Caleb Raitto > > Print the name of the argument that wasn't understood. > > Signed-off-by: Caleb Raitto That is simpler, thanks. Applied

[PATCH iproute2 v2] tc/mqprio: Print extra info on invalid args.

2018-09-06 Thread Caleb Raitto
From: Caleb Raitto Print the name of the argument that wasn't understood. Signed-off-by: Caleb Raitto --- tc/q_mqprio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c index 89b46002..7cd18ae1 100644 --- a/tc/q_mqprio.c +++ b/tc/q_mqprio.c

Re: [PATCH net] net/ipv6: fix incorrect fib6 gateway info after do redirect

2018-09-06 Thread David Ahern
On 9/6/18 6:57 AM, Hangbin Liu wrote: > When receive a redirect message and call rt6_do_redirect(), we allocate > a new rt6_info and set new flags and gateway info, but not update these > info to fib6_info. > > Then if a user try to get the route info via `ip route get`, he w

[PATCH net] net/ipv6: fix incorrect fib6 gateway info after do redirect

2018-09-06 Thread Hangbin Liu
When receive a redirect message and call rt6_do_redirect(), we allocate a new rt6_info and set new flags and gateway info, but not update these info to fib6_info. Then if a user try to get the route info via `ip route get`, he will still get the old default gateway, because inet6_rtm_getroute

Re: [PATCH iproute2] tc/mqprio: Print extra info on invalid args.

2018-09-06 Thread Stephen Hemminger
On Wed, 5 Sep 2018 13:24:19 -0700 Caleb Raitto wrote: > From: Caleb Raitto > > Print the name of the argument that wasn't understood, and also print > the usage string. > > Signed-off-by: Caleb Raitto The standard code pattern in iproute2 is to use invarg(). Why not use that?

[PATCH iproute2] tc/mqprio: Print extra info on invalid args.

2018-09-05 Thread Caleb Raitto
From: Caleb Raitto Print the name of the argument that wasn't understood, and also print the usage string. Signed-off-by: Caleb Raitto --- tc/q_mqprio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c index 89b46002..cf2eceb4 100644 ---

Re: [PATCH net 2/2] net_sched: Fix missing res info when create new tc_index filter

2018-08-13 Thread Cong Wang
On Mon, Aug 13, 2018 at 3:44 AM Hangbin Liu wrote: > This is because we didn't update f->result.res when create new filter. Then in > tcindex_delete() -> tcf_unbind_filter(), we will failed to find out the res > and unbind filter, which will trigger the WARN_ON() in cbq_destroy_class(). > > Fix

[PATCH net 2/2] net_sched: Fix missing res info when create new tc_index filter

2018-08-13 Thread Hangbin Liu
Li Shuang reported the following warn: [ 733.484610] WARNING: CPU: 6 PID: 21123 at net/sched/sch_cbq.c:1418 cbq_destroy_class+0x5d/0x70 [sch_cbq] [ 733.495190] Modules linked in: sch_cbq cls_tcindex sch_dsmark rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace fscache xt_CHECKSUM

Re: [PATCH net-next] r8169: remove version info

2018-08-10 Thread David Miller
From: Heiner Kallweit Date: Fri, 10 Aug 2018 21:27:55 +0200 > The version number hasn't changed for ages and in general I doubt it > provides any benefit. The message in rtl_init_one() may even be > misleading because it's printed also if something fails in probe. > Therefore let's remove the

Re: [PATCH net-next] r8169: remove version info

2018-08-10 Thread Andrew Lunn
On Fri, Aug 10, 2018 at 09:27:55PM +0200, Heiner Kallweit wrote: > The version number hasn't changed for ages and in general I doubt it > provides any benefit. The message in rtl_init_one() may even be > misleading because it's printed also if something fails in probe. > Therefore let's remove the

[PATCH net-next] r8169: remove version info

2018-08-10 Thread Heiner Kallweit
@@ -1635,7 +1633,6 @@ static void rtl8169_get_drvinfo(struct net_device *dev, struct rtl_fw *rtl_fw = tp->rtl_fw; strlcpy(info->driver, MODULENAME, sizeof(info->driver)); - strlcpy(info->version, RTL8169_VERSION, sizeof(info->version)); strlcpy(info->bus_inf

Re: [PATCH net-next] cxgb4: add support to display DCB info

2018-08-10 Thread David Miller
From: Ganesh Goudar Date: Fri, 10 Aug 2018 14:47:01 +0530 > display Data Center bridging information in debug > fs. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied.

[PATCH net-next] cxgb4: add support to display DCB info

2018-08-10 Thread Ganesh Goudar
display Data Center bridging information in debug fs. Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 2 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 193

[net-next, PATCH 1/2 v2] net: socionext: Use descriptor info instead of MMIO reads on Rx

2018-08-10 Thread Ilias Apalodimas
MMIO reads for remaining packets in queue occur (at least)twice per invocation of netsec_process_rx(). We can use the packet descriptor to identify if it's owned by the hardware and break out, avoiding the more expensive MMIO read operations. This has a ~2% increase on the pps of the Rx path when

Re: [net-next, PATCH 1/2] net: socionext: Use descriptor info instead of MMIO reads on Rx

2018-08-09 Thread Ilias Apalodimas
On Thu, Aug 09, 2018 at 05:37:15PM +0200, Arnd Bergmann wrote: > On Thu, Aug 9, 2018 at 10:02 AM Ilias Apalodimas > wrote: > > > > MMIO reads for remaining packets in queue occur (at least)twice per > > invocation of netsec_process_rx(). We can use the packet descriptor to > > identify if it's

Re: [net-next, PATCH 1/2] net: socionext: Use descriptor info instead of MMIO reads on Rx

2018-08-09 Thread Arnd Bergmann
On Thu, Aug 9, 2018 at 10:02 AM Ilias Apalodimas wrote: > > MMIO reads for remaining packets in queue occur (at least)twice per > invocation of netsec_process_rx(). We can use the packet descriptor to > identify if it's owned by the hardware and break out, avoiding the more > expensive MMIO read

[net-next, PATCH 1/2] net: socionext: Use descriptor info instead of MMIO reads on Rx

2018-08-09 Thread Ilias Apalodimas
MMIO reads for remaining packets in queue occur (at least)twice per invocation of netsec_process_rx(). We can use the packet descriptor to identify if it's owned by the hardware and break out, avoiding the more expensive MMIO read operations. This has a ~2% increase on the pps of the Rx path when

[PATCH V2 net-next 1/2] be2net: gather debug info and reset adapter (only for Lancer) on a tx-timeout

2018-07-31 Thread Suresh Reddy
This patch handles a TX-timeout as follows: 1) This patch gathers and prints the following info that can help in diagnosing the cause of a TX-timeout. a) TX queue and completion queue entries. b) SKB and TCP/UDP header details. 2) For Lancer NICs (TX-timeout recovery is not supported

[PATCH bpf-next 6/6] nfp: bpf: improve map offload info messages

2018-07-25 Thread Jakub Kicinski
FW can put constraints on map element size to maximize resource use and efficiency. When user attempts offload of a map which does not fit into those constraints an informational message is printed to kernel logs to inform user about the reason offload failed. Map offload does not have access to

Re: [RFC PATCH ghak90 (was ghak32) V3 02/10] audit: log container info of syscalls

2018-07-23 Thread Steve Grubb
On Sunday, July 22, 2018 4:55:10 PM EDT Richard Guy Briggs wrote: > On 2018-07-22 09:32, Steve Grubb wrote: > > On Saturday, July 21, 2018 4:29:30 PM EDT Richard Guy Briggs wrote: > > > > > + * audit_log_contid - report container info > > > > > + * @tsk: tas

[PATCH net-next 2/3] flow_dissector: Dissect tos and ttl from the tunnel info

2018-07-17 Thread Or Gerlitz
ECTOR_KEY_ENC_IP)) return; info = skb_tunnel_info(skb); @@ -212,6 +214,16 @@ skb_flow_dissect_tunnel_info(const struct sk_buff *skb, tp->src = key->tp_src; tp->dst = key->tp_dst; } + + if (disse

Re: [PATCH bpf-next v4 3/3] bpf: btf: print map dump and lookup with btf info

2018-07-11 Thread Jakub Kicinski
On Tue, 10 Jul 2018 20:21:11 -0700, Okash Khawaja wrote: > + if (err || btf_info.btf_size > last_size) { > + err = errno; errno may not be set in case btf_info.btf_size > last_size errno is positive, while other error return codes are negative. > + goto exit_free; >

[PATCH net-next v2 1/8] be2net: remove unused old AIC info

2018-07-10 Thread Ivan Vecera
/net/ethernet/emulex/benet/be.h @@ -187,13 +187,6 @@ struct be_eq_obj { struct be_queue_info q; char desc[32]; - /* Adaptive interrupt coalescing (AIC) info */ - bool enable_aic; - u32 min_eqd;/* in usecs */ - u32 max_eqd;/* in usec

info!!

2018-07-10 Thread Lee Morrow
Top of the day to you, this is in respect of a very beneficial transaction which you would not want to let go reply for more details, Regards, Lee

[PATCH v4 iproute2-next 1/3] uapi pkt_sched: Add etf info - DO NOT COMMIT

2018-07-09 Thread Jesus Sanchez-Palencia
This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH bpf-next v2 3/6] nfp: bpf: copy range info for all operands of all ALU operations

2018-07-06 Thread Jakub Kicinski
From: Jiong Wang NFP verifier hook is coping range information of the shift amount for indirect shift operation so optimized shift sequences could be generated. We want to use range info to do more things. For example, to decide whether multiplication and divide are supported on the given range

Re: [PATCH v1 iproute2 1/2] uapi pkt_sched: Add etf info - DO NOT COMMIT

2018-07-06 Thread Stephen Hemminger
On Wed, 27 Jun 2018 15:09:11 -0700 Jesus Sanchez-Palencia wrote: > This should come from the next uapi headers update. > Sending it now just as a convenience so anyone can build tc with etf > and taprio support. > > Signed-off-by: Jesus Sanchez-Palencia This should be targeted at

[PATCH v3 iproute2 1/3] uapi pkt_sched: Add etf info - DO NOT COMMIT

2018-07-05 Thread Jesus Sanchez-Palencia
This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH v2 iproute2 1/2] uapi pkt_sched: Add etf info - DO NOT COMMIT

2018-07-03 Thread Jesus Sanchez-Palencia
This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH net-next 5/9] nfp: populate bus-info on representors

2018-06-29 Thread Jakub Kicinski
We used to leave bus-info in ethtool driver info empty for representors in case multi-PCIe-to-single-host cards make the association between PCIe device and NFP many to one. It seems these attempts are futile, we need to link the representors to one PCIe device in sysfs to get consistent naming

[PATCH v1 iproute2 1/2] uapi pkt_sched: Add etf info - DO NOT COMMIT

2018-06-27 Thread Jesus Sanchez-Palencia
This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 66 ++ 1 file changed, 66 insertions(+) diff

[RFC bpf-next 3/6] net/mlx5e: Store xdp flags and meta data info

2018-06-26 Thread Saeed Mahameed
Make xdp flags and meta data info avaiable to RQs data path, to enable xdp meta data offloads in next two patches. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 10 +++- .../net/ethernet/mellanox/mlx5/core/en_main.c | 52 +++ .../net/ethernet

Re: [PATCH bpf-next 4/7] nfp: bpf: copy range info for all operands of all ALU operations

2018-06-26 Thread Song Liu
On Sun, Jun 24, 2018 at 8:54 PM, Jakub Kicinski wrote: > From: Jiong Wang > > NFP verifier hook is coping range information of the shift amount for > indirect shift operation so optimized shift sequences could be generated. > > We want to use range info to do more things. For

[PATCH bpf-next 4/7] nfp: bpf: copy range info for all operands of all ALU operations

2018-06-24 Thread Jakub Kicinski
From: Jiong Wang NFP verifier hook is coping range information of the shift amount for indirect shift operation so optimized shift sequences could be generated. We want to use range info to do more things. For example, to decide whether multiplication and divide are supported on the given range

[PATCH net-next 1/8] be2net: remove unused old AIC info

2018-06-21 Thread Ivan Vecera
/net/ethernet/emulex/benet/be.h @@ -187,13 +187,6 @@ struct be_eq_obj { struct be_queue_info q; char desc[32]; - /* Adaptive interrupt coalescing (AIC) info */ - bool enable_aic; - u32 min_eqd;/* in usecs */ - u32 max_eqd;/* in usec

Re: [RFC PATCH ghak90 (was ghak32) V3 02/10] audit: log container info of syscalls

2018-06-06 Thread Steve Grubb
1332/* Container ID */ > > #define AUDIT_AVC1400/* SE Linux avc denial or grant */ > #define AUDIT_SELINUX_ERR1401/* Internal SE Linux Errors */ > diff --git a/kernel/audit.c b/kernel/audit.c > index e7478cb..5e150c6 100644 > --- a/kernel

Re: INFO: rcu detected stall in is_bpf_text_address

2018-05-28 Thread Marcelo Ricardo Leitner
On Sun, May 20, 2018 at 04:26:03PM +0800, Xin Long wrote: > On Sat, May 19, 2018 at 11:57 PM, Eric Dumazet wrote: > > SCTP experts, please take a look. > > > > On 05/19/2018 08:55 AM, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:73fcb1a370c7

Re: INFO: rcu detected stall in is_bpf_text_address

2018-05-28 Thread Marcelo Ricardo Leitner
On Sun, May 20, 2018 at 04:26:03PM +0800, Xin Long wrote: > On Sat, May 19, 2018 at 11:57 PM, Eric Dumazet wrote: > > SCTP experts, please take a look. > > > > On 05/19/2018 08:55 AM, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:73fcb1a370c7

Re: INFO: rcu detected stall in skb_free_head

2018-05-26 Thread Dmitry Vyukov
.@syzkaller.appspotmail.com > It will help syzbot understand when the bug is fixed. See footer for > details. > If you forward the report, please keep this part and the footer. > > INFO: rcu_sched self-detected stall on CPU > 1-...!: (117917 ticks this GP) idle=036/1/461

Re: INFO: rcu detected stall in kmem_cache_alloc_node_trace

2018-05-26 Thread Dmitry Vyukov
int in max_burst socket > option. > Use struct sctp_assoc_value instead > sctp: [Deprecated]: syz-executor3 (pid 10218) Use of int in max_burst socket > option. > Use struct sctp_assoc_value instead > random: crng init done > INFO: rcu_sched self-detected stall on CPU >

Re: INFO: rcu detected stall in sctp_generate_heartbeat_event

2018-05-26 Thread Dmitry Vyukov
On Tue, May 8, 2018 at 2:06 PM, Marcelo Ricardo Leitner wrote: > On Tue, May 08, 2018 at 12:35:02AM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:90278871d4b0 Merge git://git.kernel.org/pub/scm/linux/kern.. >> git tree:

Re: INFO: rcu detected stall in kfree_skbmem

2018-05-26 Thread Dmitry Vyukov
n. Is it possible that we >> are just enqueuing so many frames for xmit that we are blocking progress of >> other threads using the same socket that we cross the RCU self detected stall >> boundary? While its not a fix per se, it might be a worthwhile test to limit >>

Re: INFO: rcu detected stall in sctp_packet_transmit

2018-05-26 Thread Dmitry Vyukov
erimental) >>>>> >>>>> Unfortunately, I don't have any reproducer for this crash yet. >>>>> >>>>> IMPORTANT: if you fix the bug, please add the following tag to the commit: >>>>> Reported-by: syzbot+ff0b569fb5111dcd1...@syzkall

  1   2   3   4   5   6   7   8   9   10   >