Re: [PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-14 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 01:30:08PM +0100, Pablo Neira Ayuso wrote: > Hi Greg, > > I'd appreciate if you can take this patch into 4.9-stable. There is no > similar patch in tree, so this is not a backport. > > On Wed, Dec 13, 2017 at 03:33:37PM -0500, Debabrata Banerjee wrote: > > A verdict of

Re: [PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-14 Thread Pablo Neira Ayuso
Hi Greg, I'd appreciate if you can take this patch into 4.9-stable. There is no similar patch in tree, so this is not a backport. On Wed, Dec 13, 2017 at 03:33:37PM -0500, Debabrata Banerjee wrote: > A verdict of NF_STOLEN after NF_QUEUE will cause an incorrect return value > and a potential

Re: [PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-12 Thread Pablo Neira Ayuso
On Tue, Dec 12, 2017 at 12:36:35AM +, Banerjee, Debabrata wrote: > > From: Pablo Neira Ayuso [mailto:pa...@netfilter.org] > > On Mon, Dec 11, 2017 at 06:30:24PM -0500, Debabrata Banerjee wrote: > > > + } else { > > > + /* Implicit handling for NF_STOLEN, as well as any other > > > +

RE: [PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-11 Thread Banerjee, Debabrata
> From: Pablo Neira Ayuso [mailto:pa...@netfilter.org] > On Mon, Dec 11, 2017 at 06:30:24PM -0500, Debabrata Banerjee wrote: > > + } else { > > + /* Implicit handling for NF_STOLEN, as well as any other > > +* non conventional verdicts. > > +*/ > > +

Re: [PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-11 Thread Pablo Neira Ayuso
Hi, Thanks for catching up this, see below. On Mon, Dec 11, 2017 at 06:30:24PM -0500, Debabrata Banerjee wrote: > A verdict of NF_STOLEN after NF_QUEUE will cause an incorrect return value > and a potential kernel panic via double free of skb's > > This was broken by commit 7034b566a4e7