Re: [PATCH net] net: dsa: ksz: fix skb freeing

2017-08-11 Thread David Miller
From: Vivien Didelot Date: Wed, 9 Aug 2017 16:46:09 -0400 > The DSA layer frees the original skb when an xmit function returns NULL, > meaning an error occurred. But if the tagging code copied the original > skb, it is responsible of freeing the copy if an error occurs. > > The ksz tagging code

RE: [PATCH net] net: dsa: ksz: fix skb freeing

2017-08-09 Thread Woojung.Huh
> The DSA layer frees the original skb when an xmit function returns NULL, > meaning an error occurred. But if the tagging code copied the original > skb, it is responsible of freeing the copy if an error occurs. > > The ksz tagging code currently has two issues: if skb_put_padto fails, > the skb

Re: [PATCH net] net: dsa: ksz: fix skb freeing

2017-08-09 Thread Andrew Lunn
Hi Vivien You missed sending a copy to Woojung Huh. Andrew On Wed, Aug 09, 2017 at 04:46:09PM -0400, Vivien Didelot wrote: > The DSA layer frees the original skb when an xmit function returns NULL, > meaning an error occurred. But if the tagging code copied the original > skb, it is responsi