Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-13 Thread 'Marcelo Ricardo Leitner'
On Fri, Sep 13, 2019 at 01:31:22PM +, David Laight wrote: > From: 'Marcelo Ricardo Leitner' > > Sent: 13 September 2019 14:20 > ... > > Interestingly, we have/had the opposite problem with netlink. Like, it > > was allowing too much flexibility, such as silently ignoring unknown > > fields (whi

RE: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-13 Thread David Laight
From: 'Marcelo Ricardo Leitner' > Sent: 13 September 2019 14:20 ... > Interestingly, we have/had the opposite problem with netlink. Like, it > was allowing too much flexibility, such as silently ignoring unknown > fields (which is what would happen with a new app running on an older > kernel would

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-13 Thread 'Marcelo Ricardo Leitner'
On Fri, Sep 13, 2019 at 08:36:22AM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 12 September 2019 23:52 > ... > > Here it is more visible. If net->...ps_retrans is disabled, remaining > > fields (currently just this one, but as we are extending it now, we > > have to think a

RE: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-13 Thread David Laight
From: Marcelo Ricardo Leitner > Sent: 12 September 2019 23:52 ... > Here it is more visible. If net->...ps_retrans is disabled, remaining > fields (currently just this one, but as we are extending it now, we > have to think about the possibility of more as well) will be ignored, > we and we may not

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-12 Thread Marcelo Ricardo Leitner
On Thu, Sep 12, 2019 at 01:47:08AM +0800, Xin Long wrote: > On Wed, Sep 11, 2019 at 8:56 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Sep 11, 2019 at 05:38:33PM +0800, Xin Long wrote: > > > On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > > > > > > > On Wed, Sep 11, 2019 at 5:03 PM Davi

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Wed, Sep 11, 2019 at 8:56 PM Marcelo Ricardo Leitner wrote: > > On Wed, Sep 11, 2019 at 05:38:33PM +0800, Xin Long wrote: > > On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > > > > > On Wed, Sep 11, 2019 at 5:03 PM David Laight > > > wrote: > > > > > > > > From: Xin Long [mailto:lucien...

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Marcelo Ricardo Leitner
On Wed, Sep 11, 2019 at 05:38:33PM +0800, Xin Long wrote: > On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > > > On Wed, Sep 11, 2019 at 5:03 PM David Laight > > wrote: > > > > > > From: Xin Long [mailto:lucien@gmail.com] > > > > Sent: 11 September 2019 09:52 > > > > On Tue, Sep 10, 2019

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > On Wed, Sep 11, 2019 at 5:03 PM David Laight wrote: > > > > From: Xin Long [mailto:lucien@gmail.com] > > > Sent: 11 September 2019 09:52 > > > On Tue, Sep 10, 2019 at 9:19 PM David Laight > > > wrote: > > > > > > > > From: Xin Long > > > >

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Wed, Sep 11, 2019 at 5:03 PM David Laight wrote: > > From: Xin Long [mailto:lucien@gmail.com] > > Sent: 11 September 2019 09:52 > > On Tue, Sep 10, 2019 at 9:19 PM David Laight > > wrote: > > > > > > From: Xin Long > > > > Sent: 09 September 2019 08:57 > > > > Section 7.2 of rfc7829: "Pee

RE: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread David Laight
From: Xin Long [mailto:lucien@gmail.com] > Sent: 11 September 2019 09:52 > On Tue, Sep 10, 2019 at 9:19 PM David Laight wrote: > > > > From: Xin Long > > > Sent: 09 September 2019 08:57 > > > Section 7.2 of rfc7829: "Peer Address Thresholds (SCTP_PEER_ADDR_THLDS) > > > Socket Option" extends '

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Tue, Sep 10, 2019 at 9:19 PM David Laight wrote: > > From: Xin Long > > Sent: 09 September 2019 08:57 > > Section 7.2 of rfc7829: "Peer Address Thresholds (SCTP_PEER_ADDR_THLDS) > > Socket Option" extends 'struct sctp_paddrthlds' with 'spt_pathcpthld' > > added to allow a user to change ps_retr

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-11 Thread Xin Long
On Wed, Sep 11, 2019 at 1:27 AM David Miller wrote: > > From: Xin Long > Date: Mon, 9 Sep 2019 15:56:51 +0800 > > > diff --git a/include/uapi/linux/sctp.h b/include/uapi/linux/sctp.h > > index a15cc28..dfd81e1 100644 > > --- a/include/uapi/linux/sctp.h > > +++ b/include/uapi/linux/sctp.h > > @@

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-10 Thread David Miller
From: Xin Long Date: Mon, 9 Sep 2019 15:56:51 +0800 > diff --git a/include/uapi/linux/sctp.h b/include/uapi/linux/sctp.h > index a15cc28..dfd81e1 100644 > --- a/include/uapi/linux/sctp.h > +++ b/include/uapi/linux/sctp.h > @@ -1069,6 +1069,7 @@ struct sctp_paddrthlds { > struct sockaddr_st

RE: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-10 Thread David Laight
From: Xin Long > Sent: 09 September 2019 08:57 > Section 7.2 of rfc7829: "Peer Address Thresholds (SCTP_PEER_ADDR_THLDS) > Socket Option" extends 'struct sctp_paddrthlds' with 'spt_pathcpthld' > added to allow a user to change ps_retrans per sock/asoc/transport, as > other 2 paddrthlds: pf_retrans,