Re: [BNEP] Fix compat BNEPGETCONNLIST ioctl.

2006-09-18 Thread Marcel Holtmann
Hi David, We were making no attempt to deal with the fact that a structure with a uint32_t followed by a pointer is going to be _different_ for 32-bit and 64-bit userspace. Any 32-bit process trying to use BNEPGETCONNLIST will be failing with -EFAULT if it's lucky; suffering from having the

Re: [BNEP] Fix compat BNEPGETCONNLIST ioctl.

2006-09-18 Thread David Woodhouse
On Mon, 2006-09-18 at 12:38 +0200, Marcel Holtmann wrote: Hi David, We were making no attempt to deal with the fact that a structure with a uint32_t followed by a pointer is going to be _different_ for 32-bit and 64-bit userspace. Any 32-bit process trying to use BNEPGETCONNLIST will be

Re: [BNEP] Fix compat BNEPGETCONNLIST ioctl.

2006-09-18 Thread David Woodhouse
On Mon, 2006-09-18 at 14:25 +0100, David Woodhouse wrote: although HIDP mouse movement doesn't seem to be appearing in /dev/input/mice on my G5, while the 'hcidump' output looks sane enough while I move it. Ew, that's because struct hidp_connadd_req is similarly buggered for compat.

Re: [BNEP] Fix compat BNEPGETCONNLIST ioctl.

2006-09-18 Thread David Woodhouse
On Mon, 2006-09-18 at 12:38 +0200, Marcel Holtmann wrote: it seems that HIDP and CMTP will have the same problem. Finally, the CMTP version... this one is untested. [CMTP] Fix compat CMTPGETCONNLIST ioctl Signed-off-by: David Woodhouse [EMAIL PROTECTED] diff --git

Re: [BNEP] Fix compat BNEPGETCONNLIST ioctl.

2006-09-18 Thread Marcel Holtmann
Hi David, although HIDP mouse movement doesn't seem to be appearing in /dev/input/mice on my G5, while the 'hcidump' output looks sane enough while I move it. Ew, that's because struct hidp_connadd_req is similarly buggered for compat. Replacement HIDP patch to fix both at once... I