Re: [PATCH] net: Allow mac_pton() to work on non-NULL terminated strings

2018-02-26 Thread David Miller
From: Stefan Hellermann Date: Fri, 23 Feb 2018 21:17:48 +0100 > Commit 4904dbda41c8 ("ARM: orion5x: use mac_pton() helper") crashes my > QNAP TS-209 NAS early on boot. > > The boot code for the TS-209 is looping through an ext2 filesystem on a > 384kB mtd partition

Re: [PATCH] net: Allow mac_pton() to work on non-NULL terminated strings

2018-02-23 Thread Andy Shevchenko
On Fri, 2018-02-23 at 23:41 +0300, Alexey Dobriyan wrote: > On Fri, Feb 23, 2018 at 09:17:48PM +0100, Stefan Hellermann wrote: > > @@ -8,10 +8,6 @@ bool mac_pton(const char *s, u8 *mac) > > { > > int i; > > > > - /* XX:XX:XX:XX:XX:XX */ > > - if (strlen(s) < 3 * ETH_ALEN - 1) > > -

Re: [PATCH] net: Allow mac_pton() to work on non-NULL terminated strings

2018-02-23 Thread Alexey Dobriyan
On Fri, Feb 23, 2018 at 09:17:48PM +0100, Stefan Hellermann wrote: > @@ -8,10 +8,6 @@ bool mac_pton(const char *s, u8 *mac) > { > int i; > > - /* XX:XX:XX:XX:XX:XX */ > - if (strlen(s) < 3 * ETH_ALEN - 1) > - return false; > - > /* Don't dirty result unless

Re: [PATCH] net: Allow mac_pton() to work on non-NULL terminated strings

2018-02-23 Thread Andrew Lunn
On Fri, Feb 23, 2018 at 09:17:48PM +0100, Stefan Hellermann wrote: > Commit 4904dbda41c8 ("ARM: orion5x: use mac_pton() helper") crashes my > QNAP TS-209 NAS early on boot. > > The boot code for the TS-209 is looping through an ext2 filesystem on a > 384kB mtd partition (factory configuration put