Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-19 Thread Andrey Vagin
On Sat, Oct 15, 2016 at 9:36 AM, Eric W. Biederman wrote: > Andrei Vagin writes: > >> On Thu, Oct 13, 2016 at 10:06:28PM -0500, Eric W. Biederman wrote: >>> Andrei Vagin writes: >>> >>> > On Thu, Oct 13, 2016 at 10:49:38AM -0500, Eric W. Biederman wrote: >>> >> Andrei Vagin writes: >>> >> >>> >

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-15 Thread Eric W. Biederman
Andrei Vagin writes: > On Thu, Oct 13, 2016 at 10:06:28PM -0500, Eric W. Biederman wrote: >> Andrei Vagin writes: >> >> > On Thu, Oct 13, 2016 at 10:49:38AM -0500, Eric W. Biederman wrote: >> >> Andrei Vagin writes: >> >> >> >> > From: Andrey Vagin >> >> > >> >> > The operation of destroying

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-14 Thread Andrei Vagin
On Thu, Oct 13, 2016 at 10:06:28PM -0500, Eric W. Biederman wrote: > Andrei Vagin writes: > > > On Thu, Oct 13, 2016 at 10:49:38AM -0500, Eric W. Biederman wrote: > >> Andrei Vagin writes: > >> > >> > From: Andrey Vagin > >> > > >> > The operation of destroying netns is heavy and it is execute

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-14 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Thu, 13 Oct 2016 22:06:28 -0500 > Oh that is a surprise. We can definitely skip genenerating uevents for > network namespaces that are exiting because by definition no one can see > those network namespaces. If a socket existed that could see

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-13 Thread Andrei Vagin
On Thu, Oct 13, 2016 at 10:49:38AM -0500, Eric W. Biederman wrote: > Andrei Vagin writes: > > > From: Andrey Vagin > > > > The operation of destroying netns is heavy and it is executed under > > net_mutex. If many namespaces are destroyed concurrently, net_mutex can > > be locked for a long time

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-13 Thread Eric W. Biederman
Andrei Vagin writes: > On Thu, Oct 13, 2016 at 10:49:38AM -0500, Eric W. Biederman wrote: >> Andrei Vagin writes: >> >> > From: Andrey Vagin >> > >> > The operation of destroying netns is heavy and it is executed under >> > net_mutex. If many namespaces are destroyed concurrently, net_mutex ca

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-13 Thread Eric W. Biederman
Andrei Vagin writes: > From: Andrey Vagin > > The operation of destroying netns is heavy and it is executed under > net_mutex. If many namespaces are destroyed concurrently, net_mutex can > be locked for a long time. It is impossible to create a new netns during > this period of time. This may