Re: [PATCH] synopsys: remove dwc_eth_qos driver
From: Joao Pinto Date: Thu, 12 Jan 2017 09:56:18 + > This driver is no longer necessary since it was merged into stmmac. > > Acked-by: Lars Persson > Signed-off-by: Joao Pinto Applied.
Re: [PATCH] synopsys: remove dwc_eth_qos driver
On 01/12/2017 04:54 PM, Joao Pinto wrote: > Às 3:48 PM de 1/12/2017, David Miller escreveu: >> From: Joao Pinto >> Date: Thu, 12 Jan 2017 15:46:31 + >> >>> Hope we can meet in a LinuxCon soon and have a talk, for you to know >>> me and this way you will see that I am a guy that is only focused in >>> producing work the best way possible, and nothing else. >> I do not argue your intentions. >> >> I argue the side effects of your change for the ecosystem of >> long term maintaince and backporting, and what tangible benefit >> this change brings to users. >> > The driver synopsys/dwc_eth_qos is no longer necessary since it was ported to > stmmac. The merged followed all the requirements given by AXIS coleagues > Niklas > and Lars. The new stmmac solution was tested by them. In my opinion of course > there is no reason to synopsys/dwc_eth_qos to exist anymore. I am deleting > now a > synopsys/ name folder :) I did this work to improve organization and > centralize > dwc ethernet in stmmac. Hello Joao, David. Regardless of the outcome of the "to rename or not to rename" discussion, I think that merging this patch would be a good thing. Joao's dwc_eth_qos glue layer has been merged to stmmac, so it should now be safe to remove the dwc_eth_qos driver. It's much better if everyone is focusing on a single driver. > > I know that changing what is working properly is a risk, I totally understand, > and if I was a top maintainer I would have the same concern of course. But in > this case I think it is good to organize the house. My intentions are to stick > around and help developing Ethernet, like I am helping developing PCI host/. > > Thanks, > Joao
Re: [PATCH] synopsys: remove dwc_eth_qos driver
From: Joao Pinto Date: Thu, 12 Jan 2017 15:54:39 + > I know that changing what is working properly is a risk, I totally understand, > and if I was a top maintainer I would have the same concern I'm not saying you risk breaking anything. I'm saying you will make backporting bug fixes to older releases for me and every distribution maintainer unreasonably difficult.
Re: [PATCH] synopsys: remove dwc_eth_qos driver
Às 3:48 PM de 1/12/2017, David Miller escreveu: > From: Joao Pinto > Date: Thu, 12 Jan 2017 15:46:31 + > >> Hope we can meet in a LinuxCon soon and have a talk, for you to know >> me and this way you will see that I am a guy that is only focused in >> producing work the best way possible, and nothing else. > > I do not argue your intentions. > > I argue the side effects of your change for the ecosystem of > long term maintaince and backporting, and what tangible benefit > this change brings to users. > The driver synopsys/dwc_eth_qos is no longer necessary since it was ported to stmmac. The merged followed all the requirements given by AXIS coleagues Niklas and Lars. The new stmmac solution was tested by them. In my opinion of course there is no reason to synopsys/dwc_eth_qos to exist anymore. I am deleting now a synopsys/ name folder :) I did this work to improve organization and centralize dwc ethernet in stmmac. I know that changing what is working properly is a risk, I totally understand, and if I was a top maintainer I would have the same concern of course. But in this case I think it is good to organize the house. My intentions are to stick around and help developing Ethernet, like I am helping developing PCI host/. Thanks, Joao
Re: [PATCH] synopsys: remove dwc_eth_qos driver
From: Joao Pinto Date: Thu, 12 Jan 2017 15:46:31 + > Hope we can meet in a LinuxCon soon and have a talk, for you to know > me and this way you will see that I am a guy that is only focused in > producing work the best way possible, and nothing else. I do not argue your intentions. I argue the side effects of your change for the ecosystem of long term maintaince and backporting, and what tangible benefit this change brings to users.
Re: [PATCH] synopsys: remove dwc_eth_qos driver
Às 3:28 PM de 1/12/2017, David Miller escreveu: > > There is no driver named "synopsys", therefore "synopsys: " is not an > appropriate subsystem prefix. > > Subsystem prefixes have to refer to real names in the source tree in > one form or another. > > I know you guys really want to rename the stmmac driver to that, but > no agreement has occurred on that issue and therefore assuming it > has happened is not appropriate. > :) I put synopsys because it is the name of the folder where dwc_eth_qos.c is. Do you want me to change the title to "dwc_eth_qos: remove dwc_eth_qos driver"? Hope we can meet in a LinuxCon soon and have a talk, for you to know me and this way you will see that I am a guy that is only focused in producing work the best way possible, and nothing else. Thanks, Joao
Re: [PATCH] synopsys: remove dwc_eth_qos driver
There is no driver named "synopsys", therefore "synopsys: " is not an appropriate subsystem prefix. Subsystem prefixes have to refer to real names in the source tree in one form or another. I know you guys really want to rename the stmmac driver to that, but no agreement has occurred on that issue and therefore assuming it has happened is not appropriate.
