Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling
On Fri, Nov 9, 2018 at 5:35 AM Sunil Kovvuri wrote: > On Fri, Nov 9, 2018 at 2:32 AM Arnd Bergmann wrote: > > On Thu, Nov 8, 2018 at 7:36 PM wrote: > > > From: Sunil Goutham > > > > Hmm, I noticed that you use a different address as the patch author > > and the submitter. I'm guessing that "Sunil Goutham" and > > "Sunil Kovvuri" actually refer to the same person, and you just > > need to pick which of the two email addresses you want to use > > for public communication, but that's not obvious here. > > > > However, if there are actually two different Sunil's here, then > > you need to add that second Signed-off-by. > > > > No, it's just me. > Sometimes code indentation becomes messy and difficult to read, if i use > corporate mail server to submit patches. So i have been using gmail. Ok, I see. Ideally you should try to get the company mail server fixed of course. A possible workaround is to add your marvell address as an alias in gmail, which allows 'git send email' to send out mails with the other address as the sender. This may however fail if the marvell mail server uses SPF, as mail clients might then consider your mails as forged. Arnd
Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling
On Fri, Nov 9, 2018 at 2:32 AM Arnd Bergmann wrote: > > On Thu, Nov 8, 2018 at 7:36 PM wrote: > > > > From: Sunil Goutham > > Hmm, I noticed that you use a different address as the patch author > and the submitter. I'm guessing that "Sunil Goutham" and > "Sunil Kovvuri" actually refer to the same person, and you just > need to pick which of the two email addresses you want to use > for public communication, but that's not obvious here. > > However, if there are actually two different Sunil's here, then > you need to add that second Signed-off-by. > No, it's just me. Sometimes code indentation becomes messy and difficult to read, if i use corporate mail server to submit patches. So i have been using gmail. > I've taken a look at all the patches now, and found very little > sticking out that warranted a comment from my side, and > no real show-stoppers. That said, I found this series overall > much harder to understand than the previous ones, and don't > even know what to ask about it. My feeling is that it's probably > all fine, but that is purely based on a review of the individual > pieces, not the overall design and how they fit together. With the > earlier patches that I managed to get a better understanding > of, that seemed reasonable as well. > > Arnd
Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling
On Thu, Nov 8, 2018 at 7:36 PM wrote: > > From: Sunil Goutham Hmm, I noticed that you use a different address as the patch author and the submitter. I'm guessing that "Sunil Goutham" and "Sunil Kovvuri" actually refer to the same person, and you just need to pick which of the two email addresses you want to use for public communication, but that's not obvious here. However, if there are actually two different Sunil's here, then you need to add that second Signed-off-by. I've taken a look at all the patches now, and found very little sticking out that warranted a comment from my side, and no real show-stoppers. That said, I found this series overall much harder to understand than the previous ones, and don't even know what to ask about it. My feeling is that it's probably all fine, but that is purely based on a review of the individual pieces, not the overall design and how they fit together. With the earlier patches that I managed to get a better understanding of, that seemed reasonable as well. Arnd
