Re: [PATCH 03/14] net: sched: add 'delete' function to action ops

[Jiri Pirko]

Mon, May 14, 2018 at 05:12:22PM CEST, j...@resnulli.us wrote:
>Mon, May 14, 2018 at 04:27:04PM CEST, vla...@mellanox.com wrote:
>>Extend action ops with 'delete' function. Each action type to implement its
>>own delete function that doesn't depend on rtnl lock.
>>
>>Signed-off-by: Vlad Buslov 
>>---
>> include/net/act_api.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>>diff --git a/include/net/act_api.h b/include/net/act_api.h
>>index e634014..73175a3 100644
>>--- a/include/net/act_api.h
>>+++ b/include/net/act_api.h
>>@@ -100,6 +100,7 @@ struct tc_action_ops {
>>  void(*stats_update)(struct tc_action *, u64, u32, u64);
>>  size_t  (*get_fill_size)(const struct tc_action *act);
>>  struct net_device *(*get_dev)(const struct tc_action *a);
>>+ int (*delete)(struct net *net, u32 index);
>
>Probably better to squash this to patch 14.

Oh, I see you call it in patch 6. Fine.

Re: [PATCH 03/14] net: sched: add 'delete' function to action ops

[Jiri Pirko]

Mon, May 14, 2018 at 04:27:04PM CEST, vla...@mellanox.com wrote:
>Extend action ops with 'delete' function. Each action type to implement its
>own delete function that doesn't depend on rtnl lock.
>
>Signed-off-by: Vlad Buslov 
>---
> include/net/act_api.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/net/act_api.h b/include/net/act_api.h
>index e634014..73175a3 100644
>--- a/include/net/act_api.h
>+++ b/include/net/act_api.h
>@@ -100,6 +100,7 @@ struct tc_action_ops {
>   void(*stats_update)(struct tc_action *, u64, u32, u64);
>   size_t  (*get_fill_size)(const struct tc_action *act);
>   struct net_device *(*get_dev)(const struct tc_action *a);
>+  int (*delete)(struct net *net, u32 index);

Probably better to squash this to patch 14.