Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-13 Thread AceLan Kao
Okay, I'll submit a new patch with some more description of why we need this feature. Thanks. 2018-05-10 20:34 GMT+08:00 Andrew Lunn : > On Thu, May 10, 2018 at 01:58:24PM +0800, AceLan Kao wrote: >> Hi Andrew, >> >> We have some machines using Qualcomm Atheros Killer E2400 Gigabit >> Ethernet Con

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-10 Thread Andrew Lunn
On Thu, May 10, 2018 at 01:58:24PM +0800, AceLan Kao wrote: > Hi Andrew, > > We have some machines using Qualcomm Atheros Killer E2400 Gigabit > Ethernet Controller, > but none of them has the unintentional wake up issue. > We're willing to fix it if we encountered the issue, but before we can > d

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-09 Thread AceLan Kao
Hi Andrew, We have some machines using Qualcomm Atheros Killer E2400 Gigabit Ethernet Controller, but none of them has the unintentional wake up issue. We're willing to fix it if we encountered the issue, but before we can do it, we need this feature is supported by the driver. Taking the feature

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-09 Thread Andrew Lunn
On Wed, May 09, 2018 at 10:40:13AM +0800, AceLan Kao wrote: > Hi, > > I didn't get any response around one month. I didn't notice you posting an results of searching for the true problem? Please can you point me at an email archive. Andrew

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-05-08 Thread AceLan Kao
Hi, I didn't get any response around one month. I'm still here hoping you can consider accepting the WoL patch. Without that patch, people have no chance to bump into the issue and have no chance to fix it. Moreover, it leads to the dkms package be spreaded around, and it'll become a more annoyin

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-04-23 Thread AceLan Kao
Hi, May I know the final decision of this patch? Thanks. Best regards, AceLan Kao. 2018-04-10 10:40 GMT+08:00 AceLan Kao : > The problem is I don't have a machine with that wakeup issue, and I > need WoL feature. > Instead of spreading "alx with WoL" dkms package everywhere, I would > like to se

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-04-09 Thread AceLan Kao
The problem is I don't have a machine with that wakeup issue, and I need WoL feature. Instead of spreading "alx with WoL" dkms package everywhere, I would like to see it's supported in the driver and is disabled by default. Moreover, the wakeup issue may come from old Atheros chips, or result from

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-04-09 Thread David Miller
From: Andrew Lunn Date: Mon, 9 Apr 2018 14:39:10 +0200 > On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote: >> The WoL feature was reported broken and will lead to >> the system resume immediately after suspending. >> This symptom is not happening on every system, so adding >> disable_wo

Re: [PATCH 2/2] alx: add disable_wol paramenter

2018-04-09 Thread Andrew Lunn
On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote: > The WoL feature was reported broken and will lead to > the system resume immediately after suspending. > This symptom is not happening on every system, so adding > disable_wol option and disable WoL by default to prevent the issue from >