Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

2015-10-27 Thread David Miller
From: Jakub Kicinski Date: Tue, 27 Oct 2015 11:16:03 + > On Mon, 26 Oct 2015 18:23:07 -0700 (PDT), David Miller wrote: >> From: Jakub Kicinski >> Date: Fri, 23 Oct 2015 19:58:11 +0100 >> >> > +struct nfp_net_tx_buf { >> > +

Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

2015-10-27 Thread Jakub Kicinski
On Mon, 26 Oct 2015 18:23:07 -0700 (PDT), David Miller wrote: > From: Jakub Kicinski > Date: Fri, 23 Oct 2015 19:58:11 +0100 > > > +struct nfp_net_tx_buf { > > + struct sk_buff *skb; > > + dma_addr_t dma_addr; > > + short int fidx; > > + u16 pkt_cnt; > > +

Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

2015-10-26 Thread David Miller
From: Jakub Kicinski Date: Fri, 23 Oct 2015 19:58:11 +0100 > +struct nfp_net_tx_buf { > + struct sk_buff *skb; > + dma_addr_t dma_addr; > + short int fidx; > + u16 pkt_cnt; > + u32 real_len; > +}; This packs very poorly, and has a lot of padding