Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-09-30 Thread Arnd Bergmann
Am Saturday 30 September 2006 01:17 schrieb Linas Vepstas: Implement basic low-watermark support for the transmit queue. Hardware low-watermarks allow a properly configured kernel to continously stream data to a device and not have to handle any interrupts at all in doing so. Correct

Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-08-23 Thread Linas Vepstas
On Sun, Aug 20, 2006 at 12:03:14PM +0200, Arnd Bergmann wrote: On Sunday 20 August 2006 08:31, Benjamin Herrenschmidt wrote: card-low_watermark-next-dmac_cmd_status |= SPIDER_NET_DESCR_TXDESFLG; mb(); card-low_watermark-dmac_cmd_status = ~SPIDER_NET_DESCR_TXDESFLG; card-low_watermark

Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-08-20 Thread Benjamin Herrenschmidt
card-low_watermark-next-dmac_cmd_status |= SPIDER_NET_DESCR_TXDESFLG; mb(); card-low_watermark-dmac_cmd_status = ~SPIDER_NET_DESCR_TXDESFLG; card-low_watermark = card-low_watermark-next; when we queue another frame for TX. I would have expected those to be racy vs. the hardware... what if

Re: [PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-08-20 Thread Arnd Bergmann
On Sunday 20 August 2006 08:31, Benjamin Herrenschmidt wrote: card-low_watermark-next-dmac_cmd_status |= SPIDER_NET_DESCR_TXDESFLG; mb(); card-low_watermark-dmac_cmd_status = ~SPIDER_NET_DESCR_TXDESFLG; card-low_watermark = card-low_watermark-next; when we queue another frame for TX.