Re: [PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU size

2018-03-12 Thread Thomas Falcon 
On 03/11/2018 09:56 PM, David Miller wrote:
> From: Thomas Falcon 
> Date: Fri,  9 Mar 2018 13:23:56 -0600
>
>> +/* For some backing devices, mishandling of small packets
>> + * can result in a loss of connection or TX stall. Device
>> + * architects recommend that no packet should be smaller
>> + * than the minimum MTU value provided to the driver, so
>> + * pad any packets to that length
>> + */
>> +if (skb->len < netdev->min_mtu) {
>> +return skb_put_padto(skb, netdev->min_mtu);
>> +}
> Please do not use curly braces for a single statement
> basic block.
>
> Thank you.
>
Oops, sorry about that. I'll fix that and resend.

Thanks.

Re: [PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU size

2018-03-11 Thread David Miller 
From: Thomas Falcon 
Date: Fri,  9 Mar 2018 13:23:56 -0600

> + /* For some backing devices, mishandling of small packets
> +  * can result in a loss of connection or TX stall. Device
> +  * architects recommend that no packet should be smaller
> +  * than the minimum MTU value provided to the driver, so
> +  * pad any packets to that length
> +  */
> + if (skb->len < netdev->min_mtu) {
> + return skb_put_padto(skb, netdev->min_mtu);
> + }

Please do not use curly braces for a single statement
basic block.

Thank you.