Re: [PATCH RFC 00/13] phylink and sfp support

[David Miller]

From: Andrew Lunn 
Date: Sun, 6 Aug 2017 20:26:22 +0200

> On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote:
>> Hi,
>> 
>> This patch series introduces generic support for SFP sockets found on
>> various Marvell based platforms.  The idea here is to provide common
>> SFP socket support which can be re-used by network drivers as
>> appropriate, rather than each network driver having to re-implement
>> SFP socket support.
> 
> Hi Russell
> 
> Please could you repost with all the Reviewed-By added and RFC
> removed. The code should get merged then.

No need, I just merged the series into net-next.

Thanks.

Re: [PATCH RFC 00/13] phylink and sfp support

[Andrew Lunn]

On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote:
> Hi,
> 
> This patch series introduces generic support for SFP sockets found on
> various Marvell based platforms.  The idea here is to provide common
> SFP socket support which can be re-used by network drivers as
> appropriate, rather than each network driver having to re-implement
> SFP socket support.

Hi Russell

Please could you repost with all the Reviewed-By added and RFC
removed. The code should get merged then.

Thanks
Andrew

Re: [PATCH RFC 00/13] phylink and sfp support

[Florian Fainelli]

On 08/01/2017 07:39 AM, Andrew Lunn wrote:
> On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote:
>> Hi,
>>
>> This patch series introduces generic support for SFP sockets found on
>> various Marvell based platforms.  The idea here is to provide common
>> SFP socket support which can be re-used by network drivers as
>> appropriate, rather than each network driver having to re-implement
>> SFP socket support.
> 
> There is a lot of code here, and i'm not really going to understand it
> until i use it. I have a couple of boards with SFFs connected to
> switches, so i will spend some time over the next month or so to make
> DSA use phylink. As is usual, we can sort out any issues as we go
> along.
> 
> David, if it still applies cleanly, can you add it to net-next?

Agreed, this is in a good shape and the more people we can have testing
this, the better. It may be nice to include a consumer of the PHYLINK
API for other people to start copying from.
-- 
Florian

Re: [PATCH RFC 00/13] phylink and sfp support

[Andrew Lunn]

On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote:
> Hi,
> 
> This patch series introduces generic support for SFP sockets found on
> various Marvell based platforms.  The idea here is to provide common
> SFP socket support which can be re-used by network drivers as
> appropriate, rather than each network driver having to re-implement
> SFP socket support.

There is a lot of code here, and i'm not really going to understand it
until i use it. I have a couple of boards with SFFs connected to
switches, so i will spend some time over the next month or so to make
DSA use phylink. As is usual, we can sort out any issues as we go
along.

David, if it still applies cleanly, can you add it to net-next?

   Thanks
Andrew

Re: [PATCH RFC 00/13] phylink and sfp support

[Russell King - ARM Linux]

On Wed, Jul 26, 2017 at 06:44:11PM +0200, Andrew Lunn wrote:
> Do you have a git branch we can look at to see these changes. It helps
> understand the API when you can see both sides of it.

git://git.armlinux.org.uk/~rmk/linux-arm.git phy

or head to the cgit at:

git.armlinux.org.uk/cgit/linux-arm.git/log/?h=phy

Not only does that include the mvneta changes, but also the changes to
the 88x3310 driver (although incomplete, but functional.)

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Re: [PATCH RFC 00/13] phylink and sfp support

[Andrew Lunn]

On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote:
> Hi,
> 
> This patch series introduces generic support for SFP sockets found on
> various Marvell based platforms.  The idea here is to provide common
> SFP socket support which can be re-used by network drivers as
> appropriate, rather than each network driver having to re-implement
> SFP socket support.

Hi Russell

Thanks for posting these patches. I will review them once i catch up
with my backlog.

...

> I currently (but not included in this series) have code to convert
> mvneta to use phylink

Do you have a git branch we can look at to see these changes. It helps
understand the API when you can see both sides of it.

Thanks
Andrew