On Sat, Aug 11, 2018 at 4:59 PM, Daniel Borkmann <dan...@iogearbox.net> wrote: > Commit a26ca7c982cb ("bpf: btf: Add pretty print support to > the basic arraymap") and 699c86d6ec21 ("bpf: btf: add pretty > print for hash/lru_hash maps") enabled support for BTF and > dumping via BPF fs for array and hash/lru map. However, both > can be decoupled from each other such that regular BPF maps > can be supported for attaching BTF key/value information, > while not all maps necessarily need to dump via map_seq_show_elem() > callback. > > The basic sanity check which is a prerequisite for all maps > is that key/value size has to match in any case, and some maps > can have extra checks via map_check_btf() callback, e.g. > probing certain types or indicating no support in general. With > that we can also enable retrieving BTF info for per-cpu map > types and lpm. > > Signed-off-by: Daniel Borkmann <dan...@iogearbox.net> > Acked-by: Alexei Starovoitov <a...@kernel.org>
Thanks for the fix. Looks good to me. For bpftool, BTF pretty print support is missing for per-cpu maps. bpffs print for per-cpu hash/array maps need to be added as well. Will add them later. Acked-by: Yonghong Song <y...@fb.com>