Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread Stephen Hemminger
On Mon, 26 Feb 2018 22:09:03 +0200 Serhey Popovych wrote: > Serhey Popovych wrote: > > David Ahern wrote: > >> On 2/26/18 11:20 AM, Serhey Popovych wrote: > >>> Stephen Hemminger wrote: > On Thu, 22 Feb 2018 15:02:06 +0200 > Serhey Popovych

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread Serhey Popovych
Serhey Popovych wrote: > David Ahern wrote: >> On 2/26/18 11:20 AM, Serhey Popovych wrote: >>> Stephen Hemminger wrote: On Thu, 22 Feb 2018 15:02:06 +0200 Serhey Popovych wrote: > +struct iplink_parse_args { > + const char *dev; > + const char

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread Serhey Popovych
David Ahern wrote: > On 2/26/18 11:20 AM, Serhey Popovych wrote: >> Stephen Hemminger wrote: >>> On Thu, 22 Feb 2018 15:02:06 +0200 >>> Serhey Popovych wrote: >>> +struct iplink_parse_args { + const char *dev; + const char *name; + const char

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread David Ahern
On 2/26/18 11:20 AM, Serhey Popovych wrote: > Stephen Hemminger wrote: >> On Thu, 22 Feb 2018 15:02:06 +0200 >> Serhey Popovych wrote: >> >>> +struct iplink_parse_args { >>> + const char *dev; >>> + const char *name; >>> + const char *type; >>> + >>> + /* This

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread Serhey Popovych
Stephen Hemminger wrote: > On Thu, 22 Feb 2018 15:02:06 +0200 > Serhey Popovych wrote: > >> +struct iplink_parse_args { >> +const char *dev; >> +const char *name; >> +const char *type; >> + >> +/* This definitely must be the last one and initialized >> +

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread Stephen Hemminger
On Thu, 22 Feb 2018 15:02:06 +0200 Serhey Popovych wrote: > +struct iplink_parse_args { > + const char *dev; > + const char *name; > + const char *type; > + > + /* This definitely must be the last one and initialized > + * by the caller of

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread Serhey Popovych
David Ahern wrote: > On 2/22/18 6:02 AM, Serhey Popovych wrote: >> Introduce new @struct iplink_parse_args data structure to consolidate >> arguments to iplink_parse(). This will reduce number of arguments >> passed to it. >> >> Pass this data structure to ->parse_opt() in iplink specific modules:

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-26 Thread Serhey Popovych
David Ahern wrote: > On 2/22/18 6:02 AM, Serhey Popovych wrote: >> Introduce new @struct iplink_parse_args data structure to consolidate >> arguments to iplink_parse(). This will reduce number of arguments >> passed to it. >> >> Pass this data structure to ->parse_opt() in iplink specific modules:

Re: [PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-25 Thread David Ahern
On 2/22/18 6:02 AM, Serhey Popovych wrote: > Introduce new @struct iplink_parse_args data structure to consolidate > arguments to iplink_parse(). This will reduce number of arguments > passed to it. > > Pass this data structure to ->parse_opt() in iplink specific modules: > it may be used to get