Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-10 Thread Andreas Färber
Am 09.08.2018 um 15:23 schrieb Ben Whitten: >> BTW we'll need this regmap conversion for the picoGW_hal, >> so once we >> have a working SPI regmap driver, we'll need to split out the >> SPI bits, >> similar to sx125x. > > I am unfamiliar with the picoGW_hal, do they expose the sx1301 > as a devic

RE: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-09 Thread Ben Whitten
> To: Ben Whitten ; Ben > Whitten > Cc: starni...@g.ncu.edu.tw; hasnain.v...@arm.com; > netdev@vger.kernel.org; Xue Liu > ; Sebastian Heß > > Subject: Re: [PATCH lora-next 01/10] net: lora: sx1301: add > register, bit-fields, and helpers for regmap > > + Xue Liu

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
+ Xue Liu + Sebastian Am 08.08.2018 um 17:52 schrieb Ben Whitten: >> Subject: Re: [PATCH lora-next 01/10] net: lora: sx1301: add >> register, bit-fields, and helpers for regmap >> >> Am 08.08.2018 um 14:32 schrieb Ben Whitten: >>>>> drivers/net/lora/K

RE: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Ben Whitten
> Subject: Re: [PATCH lora-next 01/10] net: lora: sx1301: add > register, bit-fields, and helpers for regmap > > Am 08.08.2018 um 14:32 schrieb Ben Whitten: > >>> drivers/net/lora/Kconfig | 1 + > >>&

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
Am 08.08.2018 um 14:32 schrieb Ben Whitten: >>> drivers/net/lora/Kconfig | 1 + >>> drivers/net/lora/sx1301.c | 282 >> +++--- >>> drivers/net/lora/sx1301.h | 169 >> +++ >>> 3 files changed, 439 insertions(+), 13 deletions(-) >>>

RE: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Ben Whitten
> Subject: Re: [PATCH lora-next 01/10] net: lora: sx1301: add > register, bit-fields, and helpers for regmap > > Am 07.08.2018 um 19:32 schrieb Ben Whitten: > > From: Ben Whitten > > > > The register and bit-field definitions are taken from the > SX1301 > >

RE: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Ben Whitten
> Subject: Re: [PATCH lora-next 01/10] net: lora: sx1301: add > register, bit-fields, and helpers for regmap > > Am 07.08.2018 um 19:32 schrieb Ben Whitten: > > diff --git a/drivers/net/lora/sx1301.c > b/drivers/net/lora/sx1301.c > > index 5342b61..49958f0 100644 > &

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
Am 07.08.2018 um 19:32 schrieb Ben Whitten: > diff --git a/drivers/net/lora/sx1301.c b/drivers/net/lora/sx1301.c > index 5342b61..49958f0 100644 > --- a/drivers/net/lora/sx1301.c > +++ b/drivers/net/lora/sx1301.c [...] > @@ -76,8 +287,29 @@ struct sx1301_priv { > struct gpio_desc *rst_gpio; >

Re: [PATCH lora-next 01/10] net: lora: sx1301: add register, bit-fields, and helpers for regmap

2018-08-08 Thread Andreas Färber
Am 07.08.2018 um 19:32 schrieb Ben Whitten: > From: Ben Whitten > > The register and bit-field definitions are taken from the SX1301 > datasheet version 2.01 dated June 2014 with the revision information > 'First released version'. > > The reset state and RW capability of each field is not refle