Re: [PATCH net] fib_semantics: Don't match route with mismatching tclassid

2018-02-14 Thread Stefano Brivio
Hi David, On Wed, 14 Feb 2018 10:46:05 -0700 David Ahern wrote: > On 2/14/18 10:28 AM, Stefano Brivio wrote: > > > +#ifdef CONFIG_IP_ROUTE_CLASSID > > + if (cfg->fc_flow != fi->fib_nh->nh_tclassid) > > + return 1; > > +#endif > > you should

Re: [PATCH net] fib_semantics: Don't match route with mismatching tclassid

2018-02-14 Thread David Ahern
On 2/14/18 10:28 AM, Stefano Brivio wrote: > In fib_nh_match(), if output interface or gateway are passed in > the FIB configuration, we don't have to check next hops of > multipath routes to conclude whether we have a match or not. > > However, we might still have routes with different realms >