Re: [PATCH net] l2tp: do not accept arbitrary sockets
On Tue, Mar 06, 2018 at 07:54:53AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > In another patch, we shall replace all pr_err() by less intrusive > pr_debug() so that syzkaller can find other bugs faster. > Or maybe just remove them entirely. These messages aren't very useful anyway, especially if disabled by default.
Re: [PATCH net] l2tp: do not accept arbitrary sockets
From: Eric Dumazet
Date: Tue, 06 Mar 2018 07:54:53 -0800
> From: Eric Dumazet
>
> syzkaller found an issue caused by lack of sufficient checks
> in l2tp_tunnel_create()
>
> RAW sockets can not be considered as UDP ones for instance.
>
> In another patch, we shall replace all pr_err() by less intrusive
> pr_debug() so that syzkaller can find other bugs faster.
...
> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp
> parts")
> Signed-off-by: Eric Dumazet
> Reported-by: syzbot
Applied and queued up for -stable, thanks.
Re: [PATCH net] l2tp: do not accept arbitrary sockets
On 6 March 2018 at 15:54, Eric Dumazet wrote: > From: Eric Dumazet > > syzkaller found an issue caused by lack of sufficient checks > in l2tp_tunnel_create() > > RAW sockets can not be considered as UDP ones for instance. Acked-by: James Chapman
Re: [PATCH net] l2tp: do not accept arbitrary sockets
On Tue, Mar 06, 2018 at 07:54:53AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > syzkaller found an issue caused by lack of sufficient checks > in l2tp_tunnel_create() > > RAW sockets can not be considered as UDP ones for instance. > Indeed, missing checks have been the source of so many reports. Acked-by: Guillaume Nault
