Re: [PATCH net] net/ipv6: Increment OUTxxx counters after netfilter hook

2018-04-10 Thread Sasha Levin 
Hi,

[This is an automated email]

This commit has been processed by the -stable helper bot and determined
to be a high probability candidate for -stable trees. (score: 5.8567)

The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, 
v4.4.127.

v4.16.1: Build OK!
v4.15.16: Build OK!
v4.14.33: Build OK!
v4.9.93: Build OK!
v4.4.127: Failed to apply! Possible dependencies:
1d0155035918 ("ipv6: rename IP6_INC_STATS_BH()")


Please let us know if you'd like to have this patch included in a stable tree.

--
Thanks,
Sasha

Re: [PATCH net] net/ipv6: Increment OUTxxx counters after netfilter hook

2018-04-05 Thread David Miller 
From: Jeff Barnhill <0xeff...@gmail.com>
Date: Thu,  5 Apr 2018 21:29:47 +

> At the end of ip6_forward(), IPSTATS_MIB_OUTFORWDATAGRAMS and
> IPSTATS_MIB_OUTOCTETS are incremented immediately before the NF_HOOK call
> for NFPROTO_IPV6 / NF_INET_FORWARD.  As a result, these counters get
> incremented regardless of whether or not the netfilter hook allows the
> packet to continue being processed.  This change increments the counters
> in ip6_forward_finish() so that it will not happen if the netfilter hook
> chooses to terminate the packet, which is similar to how IPv4 works.
> 
> Signed-off-by: Jeff Barnhill <0xeff...@gmail.com>

Yep, this is more consistent with ipv4.

Applied, thank you.