Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Pablo Neira Ayuso
On Thu, Aug 17, 2017 at 11:24:00PM +1200, Xin Long wrote: > On Thu, Aug 17, 2017 at 10:33 PM, Pablo Neira Ayuso > wrote: > > On Thu, Aug 17, 2017 at 12:02:20PM +0200, Pablo Neira Ayuso wrote: > >> On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: > >> > On Wed, Aug

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Xin Long
On Thu, Aug 17, 2017 at 10:33 PM, Pablo Neira Ayuso wrote: > On Thu, Aug 17, 2017 at 12:02:20PM +0200, Pablo Neira Ayuso wrote: >> On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: >> > On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: >> > >

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Pablo Neira Ayuso
On Thu, Aug 17, 2017 at 12:02:20PM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: > > On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: > > > On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: > > >> On Tue,

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Pablo Neira Ayuso
On Wed, Aug 16, 2017 at 08:39:44PM +1200, Xin Long wrote: > On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: > > On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: > >> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: > >>>

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-17 Thread Xin Long
On Thu, Aug 17, 2017 at 5:57 PM, Cong Wang wrote: > On Wed, Aug 16, 2017 at 1:39 AM, Xin Long wrote: >> On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: >>> On Mon, Aug 7, 2017 at 7:33 PM, Xin Long

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-16 Thread Cong Wang
On Wed, Aug 16, 2017 at 1:39 AM, Xin Long wrote: > On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: >> On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: >>> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-16 Thread Xin Long
On Wed, Aug 9, 2017 at 7:33 AM, Cong Wang wrote: > On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: >> On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: >>> This looks like a completely API burden? >> netfilter xt targets

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-08 Thread Cong Wang
On Mon, Aug 7, 2017 at 7:33 PM, Xin Long wrote: > On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: >> This looks like a completely API burden? > netfilter xt targets are not really compatible with netsched action. > I've got to say, the patch is

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-07 Thread Xin Long
On Tue, Aug 8, 2017 at 9:15 AM, Cong Wang wrote: > (Cc'ing netfilter and Jamal) > > On Sat, Aug 5, 2017 at 4:35 AM, Xin Long wrote: >> As we know in some target's checkentry it may dereference par.entryinfo >> to check entry stuff inside. But when

Re: [PATCH net] net: sched: fix NULL pointer dereference when action calls some targets

2017-08-07 Thread Cong Wang
(Cc'ing netfilter and Jamal) On Sat, Aug 5, 2017 at 4:35 AM, Xin Long wrote: > As we know in some target's checkentry it may dereference par.entryinfo > to check entry stuff inside. But when sched action calls xt_check_target, > par.entryinfo is set with NULL. It would