Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread Eric Dumazet
On Thu, 2016-10-13 at 09:54 -0400, David Miller wrote: > Applied, thanks Eric. > > Want me to queue this up for -stable too? No thanks, it just occurred to me during a debugging session.

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread David Miller
From: Eric Dumazet Date: Sun, 09 Oct 2016 20:25:55 -0700 > From: Eric Dumazet > > There are two ways to get tc filters from kernel to user space. > > 1) Full dump (tc_dump_tfilter()) > 2) RTM_GETTFILTER to get one precise filter, reducing overhead.

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 03:46 AM, Eric Dumazet wrote: On Wed, 2016-10-12 at 09:36 -0700, Cong Wang wrote: On Sun, Oct 9, 2016 at 8:25 PM, Eric Dumazet wrote: + if (unicast) + return netlink_unicast(net->rtnl, skb, portid, MSG_DONTWAIT); Nit: rtnl_unicast() is

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread Eric Dumazet
On Wed, 2016-10-12 at 09:36 -0700, Cong Wang wrote: > On Sun, Oct 9, 2016 at 8:25 PM, Eric Dumazet wrote: > > + if (unicast) > > + return netlink_unicast(net->rtnl, skb, portid, > > MSG_DONTWAIT); > > Nit: rtnl_unicast() is simpler. I copied code in

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-12 Thread Cong Wang
On Sun, Oct 9, 2016 at 8:25 PM, Eric Dumazet wrote: > + if (unicast) > + return netlink_unicast(net->rtnl, skb, portid, MSG_DONTWAIT); Nit: rtnl_unicast() is simpler.

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-10 Thread Jamal Hadi Salim
On 16-10-09 11:25 PM, Eric Dumazet wrote: From: Eric Dumazet There are two ways to get tc filters from kernel to user space. 1) Full dump (tc_dump_tfilter()) 2) RTM_GETTFILTER to get one precise filter, reducing overhead. The second operation is unfortunately