Re: [PATCH net] sctp: fix some copy-paste errors for file comments

[Xin Long]

On Mon, Feb 12, 2018 at 10:12 PM, Neil Horman  wrote:
> On Mon, Feb 12, 2018 at 06:30:34PM +0800, Xin Long wrote:
>> This patch is to fix the file comments in stream.c and
>> stream_interleave.c
>>
>> Fixes: a83863174a61 ("sctp: prepare asoc stream for stream reconf")
>> Fixes: 0c3f6f655487 ("sctp: implement make_datafrag for 
>> sctp_stream_interleave")
>> Signed-off-by: Xin Long 
>> ---
>>  net/sctp/stream.c| 2 +-
>>  net/sctp/stream_interleave.c | 3 ++-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sctp/stream.c b/net/sctp/stream.c
>> index cedf672..0850e2a 100644
>> --- a/net/sctp/stream.c
>> +++ b/net/sctp/stream.c
>> @@ -6,7 +6,7 @@
>>   *
>>   * This file is part of the SCTP kernel implementation
>>   *
>> - * These functions manipulate sctp tsn mapping array.
>> + * These functions work for sctp stream basic operation and reconfig.
>>   *
> If you're going to change it, I'm not sure I'd even put a comment in here.  If
> you insist on documenting the purpose of the file, I'd use something even more
> generic, like:
>
> This file contains sctp stream maniuplation primitives and helpers.
Sure, let's use this generic one, will post v2. Thanks.

>
> Neil
>
>>   * This SCTP implementation is free software;
>>   * you can redistribute it and/or modify it under the terms of
>> diff --git a/net/sctp/stream_interleave.c b/net/sctp/stream_interleave.c
>> index 8c7cf8f..c19fd42 100644
>> --- a/net/sctp/stream_interleave.c
>> +++ b/net/sctp/stream_interleave.c
>> @@ -3,7 +3,8 @@
>>   *
>>   * This file is part of the SCTP kernel implementation
>>   *
>> - * These functions manipulate sctp stream queue/scheduling.
>> + * These functions implement sctp stream message interleaving, mostly
>> + * including I-DATA and I-FORWARD-TSN chunks process.
>>   *
>>   * This SCTP implementation is free software;
>>   * you can redistribute it and/or modify it under the terms of
>> --
>> 2.1.0
>>
>>

Re: [PATCH net] sctp: fix some copy-paste errors for file comments

[Neil Horman]

On Mon, Feb 12, 2018 at 06:30:34PM +0800, Xin Long wrote:
> This patch is to fix the file comments in stream.c and
> stream_interleave.c
> 
> Fixes: a83863174a61 ("sctp: prepare asoc stream for stream reconf")
> Fixes: 0c3f6f655487 ("sctp: implement make_datafrag for 
> sctp_stream_interleave")
> Signed-off-by: Xin Long 
> ---
>  net/sctp/stream.c| 2 +-
>  net/sctp/stream_interleave.c | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sctp/stream.c b/net/sctp/stream.c
> index cedf672..0850e2a 100644
> --- a/net/sctp/stream.c
> +++ b/net/sctp/stream.c
> @@ -6,7 +6,7 @@
>   *
>   * This file is part of the SCTP kernel implementation
>   *
> - * These functions manipulate sctp tsn mapping array.
> + * These functions work for sctp stream basic operation and reconfig.
>   *
If you're going to change it, I'm not sure I'd even put a comment in here.  If
you insist on documenting the purpose of the file, I'd use something even more
generic, like:

This file contains sctp stream maniuplation primitives and helpers.

Neil

>   * This SCTP implementation is free software;
>   * you can redistribute it and/or modify it under the terms of
> diff --git a/net/sctp/stream_interleave.c b/net/sctp/stream_interleave.c
> index 8c7cf8f..c19fd42 100644
> --- a/net/sctp/stream_interleave.c
> +++ b/net/sctp/stream_interleave.c
> @@ -3,7 +3,8 @@
>   *
>   * This file is part of the SCTP kernel implementation
>   *
> - * These functions manipulate sctp stream queue/scheduling.
> + * These functions implement sctp stream message interleaving, mostly
> + * including I-DATA and I-FORWARD-TSN chunks process.
>   *
>   * This SCTP implementation is free software;
>   * you can redistribute it and/or modify it under the terms of
> -- 
> 2.1.0
> 
>