Re: [PATCH net-next] net_sched: sch_fq: avoid calling ktime_get_ns() if not needed

2018-11-20 Thread Eric Dumazet 
On Tue, Nov 20, 2018 at 9:58 AM David Miller  wrote:
>
> From: Eric Dumazet 
> Date: Mon, 19 Nov 2018 17:30:19 -0800
>
> > There are two cases were we can avoid calling ktime_get_ns() :
> >
> > 1) Queue is empty.
> > 2) Internal queue is not empty.
> >
> > Signed-off-by: Eric Dumazet 
>
> Applied.
>
> But just to be clear, if the qdisc is empty we do not need to update
> flow credits etc.?

That is right, nothing needs to be done.

Re: [PATCH net-next] net_sched: sch_fq: avoid calling ktime_get_ns() if not needed

2018-11-20 Thread David Miller 
From: Eric Dumazet 
Date: Mon, 19 Nov 2018 17:30:19 -0800

> There are two cases were we can avoid calling ktime_get_ns() :
> 
> 1) Queue is empty.
> 2) Internal queue is not empty.
> 
> Signed-off-by: Eric Dumazet 

Applied.

But just to be clear, if the qdisc is empty we do not need to update
flow credits etc.?