Re: [PATCH net-next] selftests/bpf: make correct use of exit codes in bpf selftests

[David Miller]

From: Jesper Dangaard Brouer 
Date: Tue, 13 Jun 2017 15:17:19 +0200

> The selftests depend on using the shell exit code as a mean of
> detecting the success or failure of test-binary executed.  The
> appropiate output "[PASS]" or "[FAIL]" in generated by
> tools/testing/selftests/lib.mk.
> 
> Notice that the exit code is masked with 255. Thus, be careful if
> using the number of errors as the exits code, as 256 errors would be
> seen as a success.
> 
> There are two standard defined exit(3) codes:
>  /usr/include/stdlib.h
>  #define EXIT_FAILURE1   /* Failing exit status.  */
>  #define EXIT_SUCCESS0   /* Successful exit status.  */
> 
> Fix test_verifier.c to not use the negative value of variable
> "results", but instead return EXIT_FAILURE.
> 
> Fix test_align.c and test_progs.c to actually use exit codes, before
> they were always indicating success regardless of results.
> 
> Signed-off-by: Jesper Dangaard Brouer 

Applied with commit log message corrected, thanks.

Re: [PATCH net-next] selftests/bpf: make correct use of exit codes in bpf selftests

[Fengguang Wu]

On Tue, Jun 13, 2017 at 03:17:19PM +0200, Jesper Dangaard Brouer wrote:

The selftests depend on using the shell exit code as a mean of
detecting the success or failure of test-binary executed.  The
appropiate output "[PASS]" or "[FAIL]" in generated by
tools/testing/selftests/lib.mk.

Notice that the exit code is masked with 255. Thus, be careful if
using the number of errors as the exits code, as 256 errors would be


nit pick:

s/exits/exit/


printf("Summary: %d PASSED, %d FAILED\n", passes, errors);
-   return errors ? -errors : 0;
+   return errors ? EXIT_FAILURE : EXIT_SUCCESS;


Reviewed-by: Fengguang Wu 

Thanks,
Fengguang

Re: [PATCH net-next] selftests/bpf: make correct use of exit codes in bpf selftests

[Daniel Borkmann]

On 06/13/2017 03:17 PM, Jesper Dangaard Brouer wrote:

The selftests depend on using the shell exit code as a mean of
detecting the success or failure of test-binary executed.  The
appropiate output "[PASS]" or "[FAIL]" in generated by
tools/testing/selftests/lib.mk.

Notice that the exit code is masked with 255. Thus, be careful if
using the number of errors as the exits code, as 256 errors would be
seen as a success.

There are two standard defined exit(3) codes:
  /usr/include/stdlib.h
  #define EXIT_FAILURE1   /* Failing exit status.  */
  #define EXIT_SUCCESS0   /* Successful exit status.  */

Fix test_verifier.c to not use the negative value of variable
"results", but instead return EXIT_FAILURE.

Fix test_align.c and test_progs.c to actually use exit codes, before
they were always indicating success regardless of results.

Signed-off-by: Jesper Dangaard Brouer 


Acked-by: Daniel Borkmann