Re: [PATCH net-next] tcp: remove extra POLL_OUT added for finished active connect()

2017-08-03 Thread David Miller 
From: Neal Cardwell 
Date: Wed,  2 Aug 2017 15:59:58 -0400

> Commit 45f119bf936b ("tcp: remove header prediction") introduced a
> minor bug: the sk_state_change() and sk_wake_async() notifications for
> a completed active connection happen twice: once in this new spot
> inside tcp_finish_connect() and once in the existing code in
> tcp_rcv_synsent_state_process() immediately after it calls
> tcp_finish_connect(). This commit remoes the duplicate POLL_OUT
> notifications.
> 
> Fixes: 45f119bf936b ("tcp: remove header prediction")
> Signed-off-by: Neal Cardwell 

Applied, thanks.

Re: [PATCH net-next] tcp: remove extra POLL_OUT added for finished active connect()

2017-08-02 Thread Eric Dumazet 
On Wed, 2017-08-02 at 15:59 -0400, Neal Cardwell wrote:
> Commit 45f119bf936b ("tcp: remove header prediction") introduced a
> minor bug: the sk_state_change() and sk_wake_async() notifications for
> a completed active connection happen twice: once in this new spot
> inside tcp_finish_connect() and once in the existing code in
> tcp_rcv_synsent_state_process() immediately after it calls
> tcp_finish_connect(). This commit remoes the duplicate POLL_OUT
> notifications.
> 
> Fixes: 45f119bf936b ("tcp: remove header prediction")
> Signed-off-by: Neal Cardwell 
> Cc: Florian Westphal 
> Cc: Eric Dumazet 
> Cc: Yuchung Cheng 
> ---
>  net/ipv4/tcp_input.c | 5 -
>  1 file changed, 5 deletions(-)

Acked-by: Eric Dumazet