Re: [PATCH net-next 0/3] virtio-net: a fix and some updates for virtio dim

2024-01-19 Thread Heng Qi 




在 2024/1/19 下午8:28, Michael S. Tsirkin 写道:

On Tue, Jan 16, 2024 at 09:11:30PM +0800, Heng Qi wrote:

Patch 1 fixes an existing bug. Belongs to the net branch.
Patch 2 requires updating the virtio spec.
Patch 3 only attempts to modify the sending of dim cmd to an asynchronous way,
and does not affect the synchronization way of ethtool cmd.


Given this doesn't build, please document how was each patch tested.
Thanks!


There are some other local modifications. When using 'git add -ip' to 
temporarily store the patch content,
content that does not belong to this patch (struct virtnet_coal_entry) 
was mistakenly added to the patch [3/3],
and it was compiled and passed locally. Sorry for this, I will 
re-release it in the next version.


Thanks,
Heng


Heng Qi (3):
   virtio-net: fix possible dim status unrecoverable
   virtio-net: batch dim request
   virtio-net: reduce the CPU consumption of dim worker

  drivers/net/virtio_net.c| 197 
  include/uapi/linux/virtio_net.h |   1 +
  2 files changed, 182 insertions(+), 16 deletions(-)

--
1.8.3.1

Re: [PATCH net-next 0/3] virtio-net: a fix and some updates for virtio dim

2024-01-19 Thread Michael S. Tsirkin 
On Tue, Jan 16, 2024 at 09:11:30PM +0800, Heng Qi wrote:
> Patch 1 fixes an existing bug. Belongs to the net branch.
> Patch 2 requires updating the virtio spec.
> Patch 3 only attempts to modify the sending of dim cmd to an asynchronous way,
> and does not affect the synchronization way of ethtool cmd.


Given this doesn't build, please document how was each patch tested.
Thanks!

> Heng Qi (3):
>   virtio-net: fix possible dim status unrecoverable
>   virtio-net: batch dim request
>   virtio-net: reduce the CPU consumption of dim worker
> 
>  drivers/net/virtio_net.c| 197 
> 
>  include/uapi/linux/virtio_net.h |   1 +
>  2 files changed, 182 insertions(+), 16 deletions(-)
> 
> -- 
> 1.8.3.1