Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-09 Thread Shmulik Ladkani
On Sat, 9 Jul 2016 11:35:03 -0400 Hannes Frederic Sowa wrote: > On 09.07.2016 11:18, Shmulik Ladkani wrote: > > On Fri, 8 Jul 2016 19:04:27 -0400 Hannes Frederic Sowa > > wrote: > I really do wonder if GRO on top of fragmentation

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-09 Thread Hannes Frederic Sowa
On 09.07.2016 11:18, Shmulik Ladkani wrote: > On Fri, 8 Jul 2016 19:04:27 -0400 Hannes Frederic Sowa > wrote: I really do wonder if GRO on top of fragmentation does have any effect. Would be great if someone has data for that already? >>> >>> I think that

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-09 Thread Shmulik Ladkani
On Fri, 8 Jul 2016 19:04:27 -0400 Hannes Frederic Sowa wrote: > >> I really do wonder if GRO on top of fragmentation does have any effect. > >> Would be great if someone has data for that already? > > > > I think that logic is kind of backwards. It is already

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Alexander Duyck
On Fri, Jul 8, 2016 at 4:04 PM, Hannes Frederic Sowa wrote: > On 08.07.2016 18:11, Alexander Duyck wrote: >> On Fri, Jul 8, 2016 at 2:51 PM, Hannes Frederic Sowa >> wrote: >>> On 08.07.2016 17:27, Alexander Duyck wrote: On Fri, Jul 8,

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 18:11, Alexander Duyck wrote: > On Fri, Jul 8, 2016 at 2:51 PM, Hannes Frederic Sowa > wrote: >> On 08.07.2016 17:27, Alexander Duyck wrote: >>> On Fri, Jul 8, 2016 at 1:57 PM, Hannes Frederic Sowa >>> wrote: On

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Alexander Duyck
On Fri, Jul 8, 2016 at 2:51 PM, Hannes Frederic Sowa wrote: > On 08.07.2016 17:27, Alexander Duyck wrote: >> On Fri, Jul 8, 2016 at 1:57 PM, Hannes Frederic Sowa >> wrote: >>> On 08.07.2016 16:17, Shmulik Ladkani wrote: On Fri, 8 Jul

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 17:19, Shmulik Ladkani wrote: > On Fri, 8 Jul 2016 16:57:10 -0400 Hannes Frederic Sowa > wrote: >> On 08.07.2016 16:17, Shmulik Ladkani wrote: >>> On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck >>> wrote: I get that

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 17:27, Alexander Duyck wrote: > On Fri, Jul 8, 2016 at 1:57 PM, Hannes Frederic Sowa > wrote: >> On 08.07.2016 16:17, Shmulik Ladkani wrote: >>> On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck >>> wrote: On Thu, Jul 7,

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Alexander Duyck
On Fri, Jul 8, 2016 at 1:57 PM, Hannes Frederic Sowa wrote: > On 08.07.2016 16:17, Shmulik Ladkani wrote: >> On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck >> wrote: >>> On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Shmulik Ladkani
On Fri, 8 Jul 2016 16:57:10 -0400 Hannes Frederic Sowa wrote: > On 08.07.2016 16:17, Shmulik Ladkani wrote: > > On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck > > wrote: > >> I get that there is an impression that it is redundant but

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Hannes Frederic Sowa
On 08.07.2016 16:17, Shmulik Ladkani wrote: > On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck > wrote: >> On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: >>> With udp tunnel offload in place, the kernel can do GRO for some udp tunnels >>> at

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Shmulik Ladkani
On Fri, 8 Jul 2016 09:21:40 -0700 Alexander Duyck wrote: > On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: > > With udp tunnel offload in place, the kernel can do GRO for some udp tunnels > > at the ingress device level. Currently both the geneve

Re: [PATCH net-next 0/4] net: cleanup for UDP tunnel's GRO

2016-07-08 Thread Alexander Duyck
On Thu, Jul 7, 2016 at 8:58 AM, Paolo Abeni wrote: > With udp tunnel offload in place, the kernel can do GRO for some udp tunnels > at the ingress device level. Currently both the geneve and the vxlan drivers > implement an additional GRO aggregation point via gro_cells. > The