From: David Ahern <dsah...@gmail.com>
Date: Tue, 13 Feb 2018 08:37:32 -0800

> Improve efficiency of fib_tests.sh and make the test result more verbose,
> from this summary:
> $ fib_tests.sh is failing in a VM:
>     $ fib_tests.sh
>     Running netdev unregister tests
>     PASS: unicast route test
>     PASS: multipath route test
>     Running netdev down tests
>     PASS: unicast route test
>     PASS: multipath route test
>     Running netdev carrier change tests
>     PASS: local route carrier test
>     FAIL: unicast route carrier test
> 
> where a single entry actually corresponds to many checks to a much more
> verbse output that clarifies test cases:
> $fib_tests.sh
> Single path route carrier test
>     ....
>     Carrier down
>         IPv4 fibmatch                                         [ OK ]
>         IPv6 fibmatch                                         [ OK ]
>         IPv4 linkdown flag set                                [FAIL]
>         IPv6 linkdown flag set                                [FAIL]
>     Second address added with carrier down
>         IPv4 fibmatch                                         [ OK ]
>         IPv6 fibmatch                                         [ OK ]
>         IPv4 linkdown flag set                                [FAIL]
>         IPv6 linkdown flag set                                [ OK ]
> 
> And then fix the race in changing carrier down on dummy device to checking
> the corresponding routes.

Looks great, series applied, thanks David.

Reply via email to