Re: [PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware Update

2016-09-19 Thread kbuild test robot
Hi Rob, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt-update-for-net-next/20160919-161506 config: s390-allmodconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https:/

Re: [PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware Update

2016-09-19 Thread Michael Chan
On Mon, Sep 19, 2016 at 1:16 AM, Mintz, Yuval wrote: >> + if (bp->hwrm_spec_code < 0x10400) >> + return -EOPNOTSUPP; > Don't you use defines for these kind of version values? No we don't. In this case, firmware spec version 1.4.0 has added this new feature. So we use this featur

RE: [PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware Update

2016-09-19 Thread Mintz, Yuval
> + if (bp->hwrm_spec_code < 0x10400) > + return -EOPNOTSUPP; Don't you use defines for these kind of version values? > static int bnxt_flash_package_from_file(struct net_device *dev, ... > + rc = request_firmware(&fw, filename, &dev->dev); > + if (rc != 0) { If (rc) > +