From: Johannes Berg
Date: Wed, 09 Mar 2016 12:24:20 +0100
> Yeah, there's probably no way a compiler could ever do something with
> it that's not the same as packed, but it seems to me that just out of
> convention structs that have some wire-format meaning should
Hi,
Thanks for the comments.
> > > +struct gcm_iv {
> > > + union {
> > > + u8 secure_channel_id[8];
> > > + sci_t sci;
> > > + };
> > > + __be32 pn;
> > > +};
> >
> > Should this be __packed?
>
> I think that's not necessary here.
Yeah, there's probably no way a compiler
2016-03-08, 21:13:53 +0100, Johannes Berg wrote:
> On Mon, 2016-03-07 at 18:12 +0100, Sabrina Dubroca wrote:
> >
> > +struct gcm_iv {
> > + union {
> > + u8 secure_channel_id[8];
> > + sci_t sci;
> > + };
> > + __be32 pn;
> > +};
>
> Should this be __packed?
I think
On Mon, 2016-03-07 at 18:12 +0100, Sabrina Dubroca wrote:
>
> +struct gcm_iv {
> + union {
> + u8 secure_channel_id[8];
> + sci_t sci;
> + };
> + __be32 pn;
> +};
Should this be __packed?
But the struct is confusing; sci_t is a host type (that depends on
From: Sabrina Dubroca
Date: Mon, 7 Mar 2016 18:12:40 +0100
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f184fb5bd110..2a1ba62b7da2 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -193,6 +193,13 @@ config GENEVE
> To compile