Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op

2016-12-02 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > + /* Switch Software Reset */ > + int (*g1_reset)(struct mv88e6xxx_chip *chip); > + > > We have a collection of function pointers with port_ prefix, another > collection with stats_, and a third with ppu_, etc. And then we have > some which do not fit a s

Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op

2016-12-02 Thread David Miller
From: Vivien Didelot Date: Wed, 30 Nov 2016 17:59:27 -0500 > @@ -765,6 +765,9 @@ struct mv88e6xxx_ops { > int (*phy_write)(struct mv88e6xxx_chip *chip, int addr, int reg, >u16 val); > > + /* Switch Software Reset */ > + int (*reset)(struct mv88e6xxx_chip *c

Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op

2016-12-02 Thread Andrew Lunn
On Thu, Dec 01, 2016 at 03:41:20PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > >> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > >> b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > >> index ab52c37..9e51405 100644 > >> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > >> ++

Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op

2016-12-01 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> index ab52c37..9e51405 100644 >> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> @@ -765,6 +765,9 @@ struct mv88e6xxx_

Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op

2016-11-30 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > index ab52c37..9e51405 100644 > --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > @@ -765,6 +765,9 @@ struct mv88e6xxx_ops { > int (*phy_write)(struct mv