Re: [PATCH net-next 5/6] net: dsa: mv88e6xxx: add helper for switch ready

Hi Andrew, Andrew Lunn writes: > As we have seen in the past, this sort of loop is broken if we end up > sleeping for a long time. Please take the opportunity to replace it > with one of our _wait() helpers, e.g. mv88e6xxx_g1_wait() That won't work. the _wait() helpers are made

Re: [PATCH net-next 5/6] net: dsa: mv88e6xxx: add helper for switch ready

> +static int mv88e6xxx_wait_switch_ready(struct mv88e6xxx_chip *chip) > +{ > + const unsigned long timeout = jiffies + 1 * HZ; > + bool ready; > + int err; > + > + /* Wait up to 1 second for switch to be ready. > + * The switch is ready when all units inside the device (ATU,