Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 01:02:05PM +0800, Jason Wang wrote: > > > On 2017年08月15日 00:01, Michael S. Tsirkin wrote: > > On Sat, Aug 12, 2017 at 10:48:49AM +0800, Jason Wang wrote: > > > > > > On 2017年08月12日 07:12, Jakub Kicinski wrote: > > > > On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote:

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-14 Thread Jason Wang
On 2017年08月15日 00:01, Michael S. Tsirkin wrote: On Sat, Aug 12, 2017 at 10:48:49AM +0800, Jason Wang wrote: On 2017年08月12日 07:12, Jakub Kicinski wrote: On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two part

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-14 Thread Jason Wang
On 2017年08月14日 16:43, Daniel Borkmann wrote: On 08/11/2017 01:41 PM, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: [...] @@ -1402,6 +1521,22 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, skb_r

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-14 Thread Michael S. Tsirkin
On Sat, Aug 12, 2017 at 10:48:49AM +0800, Jason Wang wrote: > > > On 2017年08月12日 07:12, Jakub Kicinski wrote: > > On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: > > > This patch tries to implement XDP for tun. The implementation was > > > split into two parts: > > > > > > - fast path: sma

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-14 Thread Daniel Borkmann
On 08/11/2017 01:41 PM, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: [...] @@ -1402,6 +1521,22 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, skb_reset_network_header(skb); skb_probe_tr

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-11 Thread Jason Wang
On 2017年08月12日 07:12, Jakub Kicinski wrote: On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: - fast path: small and no gso packet. We try to do XDP at page level before build_skb(). For XDP_TX, sin

Re: [PATCH net-next V2 3/3] tap: XDP support

2017-08-11 Thread Jakub Kicinski
On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were c