Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
On Thu, 7 Mar 2024 17:36:35 +0800 Xuan Zhuo wrote: > > Please wait for this API to get merged: > > https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/ > > A lot of the stats you're adding here can go into the new API. > > More drivers can report things like number of LSO / GRO packets. > > In this patch set, I just see two for tx, three for rx. > And what stats do you want to put into this API? > > And on the other side, how should we judge whether a stat is placed in this > api > or the interface of ethtool -S? A bit of a judgment call indeed, let me reply on patch 3 and we can go over them one by one before you invest the time re-coding.
Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
On Tue, 27 Feb 2024 06:54:24 -0800, Jakub Kicinski wrote: > On Tue, 27 Feb 2024 16:03:02 +0800 Xuan Zhuo wrote: > > Now, we just show the stats of every queue. > > > > But for the user, the total values of every stat may are valuable. > > Please wait for this API to get merged: > https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/ > A lot of the stats you're adding here can go into the new API. > More drivers can report things like number of LSO / GRO packets. In this patch set, I just see two for tx, three for rx. And what stats do you want to put into this API? And on the other side, how should we judge whether a stat is placed in this api or the interface of ethtool -S? Thanks.
Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
Tue, Feb 27, 2024 at 04:41:17PM CET, k...@kernel.org wrote: >On Tue, 27 Feb 2024 16:07:13 +0100 Jiri Pirko wrote: >> >Please wait for this API to get merged: >> >https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/ >> >A lot of the stats you're adding here can go into the new API. >> >> Can. But does that mean that ethtool additions of things like this >> will be rejected after that? > >As a general policy, yes, the same way we reject duplicating other >existing stats. Makes sense.
Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
On Tue, 27 Feb 2024 16:07:13 +0100 Jiri Pirko wrote: > >Please wait for this API to get merged: > >https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/ > >A lot of the stats you're adding here can go into the new API. > > Can. But does that mean that ethtool additions of things like this > will be rejected after that? As a general policy, yes, the same way we reject duplicating other existing stats.
Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
Tue, Feb 27, 2024 at 03:54:24PM CET, k...@kernel.org wrote: >On Tue, 27 Feb 2024 16:03:02 +0800 Xuan Zhuo wrote: >> Now, we just show the stats of every queue. >> >> But for the user, the total values of every stat may are valuable. > >Please wait for this API to get merged: >https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/ >A lot of the stats you're adding here can go into the new API. Can. But does that mean that ethtool additions of things like this will be rejected after that? >More drivers can report things like number of LSO / GRO packets. >
Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
On Tue, 27 Feb 2024 16:03:02 +0800 Xuan Zhuo wrote: > Now, we just show the stats of every queue. > > But for the user, the total values of every stat may are valuable. Please wait for this API to get merged: https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/ A lot of the stats you're adding here can go into the new API. More drivers can report things like number of LSO / GRO packets.
