Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread Jason Wang
On 2018年02月09日 03:09, David Miller wrote: From: Jason Wang Date: Thu, 8 Feb 2018 11:59:25 +0800 We need limit the maximum size of queue, otherwise it may cause several side effects e.g slab will warn when the size exceeds KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread Jason Wang
On 2018年02月08日 23:50, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 03:11:22PM +0800, Jason Wang wrote: On 2018年02月08日 12:52, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: We need limit the maximum size of queue, otherwise it may cause several

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread David Miller
From: Jason Wang Date: Thu, 8 Feb 2018 11:59:25 +0800 > We need limit the maximum size of queue, otherwise it may cause > several side effects e.g slab will warn when the size exceeds > KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so this patch > tries to limit

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 03:11:22PM +0800, Jason Wang wrote: > > > On 2018年02月08日 12:52, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: > > > We need limit the maximum size of queue, otherwise it may cause > > > several side effects e.g slab will warn

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-07 Thread Jason Wang
On 2018年02月08日 12:52, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: We need limit the maximum size of queue, otherwise it may cause several side effects e.g slab will warn when the size exceeds KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

2018-02-07 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: > We need limit the maximum size of queue, otherwise it may cause > several side effects e.g slab will warn when the size exceeds > KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so this patch > tries to limit it to 64K. This