Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread David Miller
From: Roman Kapl Date: Wed, 21 Feb 2018 09:49:31 +0100 > Should I send a v3 or something, David? No, it's too late to fix it, sorry.

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread Roman Kapl
On 02/21/2018 09:42 AM, Phil Sutter wrote: Hi Roman, On Wed, Feb 21, 2018 at 09:38:52AM +0100, Roman Kapl wrote: On 02/21/2018 08:45 AM, Phil Sutter wrote: On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote: Note: The error case can happen pretty easily if you create a filter with 32

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread Phil Sutter
Hi Roman, On Wed, Feb 21, 2018 at 09:38:52AM +0100, Roman Kapl wrote: > On 02/21/2018 08:45 AM, Phil Sutter wrote: > > On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote: > >> So far, if the filter was too large to fit in the allocated skb, the > >> kernel did not return any error and

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-21 Thread Roman Kapl
On 02/21/2018 08:45 AM, Phil Sutter wrote: Hi Roman, On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote: So far, if the filter was too large to fit in the allocated skb, the kernel did not return any error and stopped dumping. Modify the dumper so that it returns -EMSGSIZE when a

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-20 Thread Phil Sutter
Hi Roman, On Mon, Feb 19, 2018 at 09:32:51PM +0100, Roman Kapl wrote: > So far, if the filter was too large to fit in the allocated skb, the > kernel did not return any error and stopped dumping. Modify the dumper > so that it returns -EMSGSIZE when a filter fails to dump and it is the > first

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-20 Thread David Miller
From: Roman Kapl Date: Mon, 19 Feb 2018 21:32:51 +0100 > So far, if the filter was too large to fit in the allocated skb, the > kernel did not return any error and stopped dumping. Modify the dumper > so that it returns -EMSGSIZE when a filter fails to dump and it is the > first

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-20 Thread Cong Wang
On Mon, Feb 19, 2018 at 12:32 PM, Roman Kapl wrote: > So far, if the filter was too large to fit in the allocated skb, the > kernel did not return any error and stopped dumping. Modify the dumper > so that it returns -EMSGSIZE when a filter fails to dump and it is the > first

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-20 Thread Jiri Pirko
Mon, Feb 19, 2018 at 09:32:51PM CET, c...@rkapl.cz wrote: >So far, if the filter was too large to fit in the allocated skb, the >kernel did not return any error and stopped dumping. Modify the dumper >so that it returns -EMSGSIZE when a filter fails to dump and it is the >first filter in the skb.