Re: [PATCH v2 0/4] PTP attribute handling cleanup

2017-02-17 Thread David Miller 
From: Richard Cochran 
Date: Thu, 16 Feb 2017 21:19:29 +0100

> On Tue, Feb 14, 2017 at 10:23:30AM -0800, Dmitry Torokhov wrote:
>>  drivers/ptp/ptp_clock.c   |  22 +++---
>>  drivers/ptp/ptp_private.h |   7 +-
>>  drivers/ptp/ptp_sysfs.c   | 167 
>> ++
>>  3 files changed, 80 insertions(+), 116 deletions(-)
> 
> Nice reduction in sysfs code!
> 
> I gave this some light testing on the coldfire/phyter (which has 12
> pins), and nothing exploded.
> 
> For the series:
> 
> Acked-by: Richard Cochran 

Series applied to net-next, thanks.

Re: [PATCH v2 0/4] PTP attribute handling cleanup

2017-02-16 Thread Richard Cochran 
On Tue, Feb 14, 2017 at 10:23:30AM -0800, Dmitry Torokhov wrote:
>  drivers/ptp/ptp_clock.c   |  22 +++---
>  drivers/ptp/ptp_private.h |   7 +-
>  drivers/ptp/ptp_sysfs.c   | 167 
> ++
>  3 files changed, 80 insertions(+), 116 deletions(-)

Nice reduction in sysfs code!

I gave this some light testing on the coldfire/phyter (which has 12
pins), and nothing exploded.

For the series:

Acked-by: Richard Cochran

Re: [PATCH v2 0/4] PTP attribute handling cleanup

2017-02-16 Thread Richard Cochran 
On Wed, Feb 15, 2017 at 12:22:15PM -0500, David Miller wrote:
> Richard, please review.

Ok, I am testing this today or tomorrow.
I'll report back as soon as I can.

Thanks,
Richard

Re: [PATCH v2 0/4] PTP attribute handling cleanup

2017-02-15 Thread David Miller 
From: Dmitry Torokhov 
Date: Tue, 14 Feb 2017 10:23:30 -0800

> PTP core was creating some attributes, such as "period" and "fifo", and the
> entire "pins" attribute group, after creating class deevice, which creates
> a race for userspace: uevent may arrive before all attributes are created.
> 
> This series of patches switches PTP to use is_visible() to control
> visibility of attributes in a group, and device_create_with_groups() to
> ensure that attributes are created before we notify userspace of a new
> device.

Richard, please review.