Re: [PATCH v2 00/10] Constify attribute_group structures
Hi Kalle, On Tuesday 25 July 2017 06:25 PM, Kalle Valo wrote: Arvind Yadavwrites: attribute_groups are not supposed to change at runtime. So mark the non-const structs as const. Arvind Yadav (10): [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures. [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures. [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures. [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures. [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures. [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures. [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures. [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures. [PATCH v2 09/10] net: bonding: constify attribute_group structures. [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures. Via which tree were you planning to push these? Is it ok if I take the wireless patches to my tree? I have push these changes to linux-next branch. you can take this to your branch. ~arvind
Re: [PATCH v2 00/10] Constify attribute_group structures
Hi Kalle, On Tuesday 25 July 2017 06:25 PM, Kalle Valo wrote: Arvind Yadavwrites: attribute_groups are not supposed to change at runtime. So mark the non-const structs as const. Arvind Yadav (10): [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures. [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures. [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures. [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures. [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures. [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures. [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures. [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures. [PATCH v2 09/10] net: bonding: constify attribute_group structures. [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures. Via which tree were you planning to push these? Is it ok if I take the wireless patches to my tree? I have push these changes to linux-branch. you can take this to your branch. ~arvind
Re: [PATCH v2 00/10] Constify attribute_group structures
Arvind Yadavwrites: > attribute_groups are not supposed to change at runtime. So mark the > non-const structs as const. > > Arvind Yadav (10): > [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures. > [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures. > [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures. > [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures. > [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures. > [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures. > [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures. > [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures. > [PATCH v2 09/10] net: bonding: constify attribute_group structures. > [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures. Via which tree were you planning to push these? Is it ok if I take the wireless patches to my tree? -- Kalle Valo
Re: [PATCH v2 00/10] Constify attribute_group structures
From: Arvind YadavDate: Tue, 11 Jul 2017 12:52:41 +0530 > attribute_groups are not supposed to change at runtime. So mark the > non-const structs as const. Please resubmit this when net-next is open again: http://vger.kernel.org/~davem/net-next.html Thank you.
Re: [PATCH v2 00/10] Constify attribute_group structures
On 07/11/2017 09:29 AM, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. So mark the > non-const structs as const. [...] > drivers/net/can/at91_can.c | 2 +- > drivers/net/can/janz-ican3.c| 2 +- For the can drivers: Acked-by: Marc Kleine-Budde-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | signature.asc Description: OpenPGP digital signature