Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

2016-09-20 Thread Jon Mason
On Tue, Sep 20, 2016 at 1:19 AM, Rafał Miłecki wrote: > On 17 August 2016 at 13:34, Rafał Miłecki wrote: >> On 8 July 2016 at 01:08, Jon Mason wrote: >>> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> >>> BGMAC_DS_MM_SHIFT; >>> - if (ci->id != BC

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

2016-09-19 Thread Rafał Miłecki
On 17 August 2016 at 13:34, Rafał Miłecki wrote: > On 8 July 2016 at 01:08, Jon Mason wrote: >> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> >> BGMAC_DS_MM_SHIFT; >> - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0) >> + if (bgmac->featu

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

2016-08-17 Thread Rafał Miłecki
On 8 July 2016 at 01:08, Jon Mason wrote: > mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> > BGMAC_DS_MM_SHIFT; > - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0) > + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0) >

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

2016-07-08 Thread Florian Fainelli
On 07/07/2016 04:08 PM, Jon Mason wrote: > The bgmac driver is using the bcma provides device ID and revision, as > well as the SoC ID and package, to determine which features are > necessary to enable, reset, etc in the driver. In anticipation of > removing the bcma requirement for this driver,