Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-20 Thread kiki good
Hi Stephen: Thanks for the suggestion of using per-cpu statistics. In this part of code, there are two major reasons not to use per-cpu variable for calculating Tx packets: 1. The update of ring->bytes and ring ->packets are protected with irq version's spin lock in the current code logic.

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-20 Thread Stephen Hemminger
On Wed, 19 Jul 2017 01:18:40 +0100 "Jianming.qiao" wrote: > Signed-off-by: Jianming.qiao You may want to consider using per-cpu statistics.

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-20 Thread Florian Fainelli
On 07/20/2017 03:13 AM, kiki good wrote: > Hi David: > > I am sorry for missing the commit log message;Since I did conversation > with Florian Fainelli about this patch in another email thread > "[PATCH] net: systemport: Support 64bit statistics", i incorrectly > thought it was unnecessary to add

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-20 Thread kiki good
Hi David: I am sorry for missing the commit log message;Since I did conversation with Florian Fainelli about this patch in another email thread "[PATCH] net: systemport: Support 64bit statistics", i incorrectly thought it was unnecessary to add the commit log again when submitting the revised

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-19 Thread David Miller
From: "Jianming.qiao" Date: Wed, 19 Jul 2017 01:18:40 +0100 > Signed-off-by: Jianming.qiao Supporting both deprecated .ndo_get_stats and 64-bit .ndo_get_stats64 at the same time makes no sense. .ndo_get_stats will never be called if .ndo_get_stats64