> @@ -488,6 +488,9 @@ static int macb_mii_probe(struct net_device *dev)
>                       }
>                       bp->phy_node = of_node_get(np);
>               } else {
> +                     /* attempt to find a phy-handle */
> +                     bp->phy_node = of_parse_phandle(np, "phy-handle", 0);
> +

Hi Brad

It seems like you should check the return value here, any only
continue with the fallback if there was not a phy-handle.

>                       /* fallback to standard phy registration if no phy were
>                        * found during dt phy registration
>                        */

         Andrew

Reply via email to