Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Apr 4, 2018 at 1:41 PM Yuchung Cheng wrote: > On Wed, Apr 4, 2018 at 10:22 AM, Neal Cardwell wrote: > > n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote: > >> Agreed. That's a good point. And I would much preferred to rename that > >> to FLAG_ORIG_PROGRESS (w/ updated comment). > > > >

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Apr 4, 2018 at 10:22 AM, Neal Cardwell wrote: > n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote: >> Agreed. That's a good point. And I would much preferred to rename that >> to FLAG_ORIG_PROGRESS (w/ updated comment). > >> so I think we're in agreement to use existing patch w/ the new n

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

n Wed, Apr 4, 2018 at 1:13 PM Yuchung Cheng wrote: > Agreed. That's a good point. And I would much preferred to rename that > to FLAG_ORIG_PROGRESS (w/ updated comment). > so I think we're in agreement to use existing patch w/ the new name > FLAG_ORIG_PROGRESS Yes, SGTM. I guess this "prevent b

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Apr 4, 2018 at 9:33 AM, Neal Cardwell wrote: > > On Wed, Apr 4, 2018 at 6:35 AM Ilpo Järvinen > wrote: > > > On Wed, 28 Mar 2018, Yuchung Cheng wrote: > > > > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > > > wrote: > > > > > > > > If SACK is not enabled and the first cumulative ACK a

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Apr 4, 2018 at 6:35 AM Ilpo Järvinen wrote: > On Wed, 28 Mar 2018, Yuchung Cheng wrote: > > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > > wrote: > > > > > > If SACK is not enabled and the first cumulative ACK after the RTO > > > retransmission covers more than the retransmitted skb

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, 28 Mar 2018, Yuchung Cheng wrote: > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > wrote: > > > > If SACK is not enabled and the first cumulative ACK after the RTO > > retransmission covers more than the retransmitted skb, a spurious > > FRTO undo will trigger (assuming FRTO is enabled

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen wrote: > > If SACK is not enabled and the first cumulative ACK after the RTO > retransmission covers more than the retransmitted skb, a spurious > FRTO undo will trigger (assuming FRTO is enabled for that RTO). > The reason is that any non-retransmitt