Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-18 Thread Leon Romanovsky
On Sun, Sep 18, 2016 at 08:36:55PM +, Adit Ranadive wrote: > On Sun, Sep 18, 2016 at 10:07:18 -0700, Leon Romanovsky wrote: > > On Thu, Sep 15, 2016 at 10:36:12AM +0300, Yuval Shaia wrote: > > > Hi Adit, > > > Please see my comments inline. > > > > > > Besides that I have no more comment for

RE: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-18 Thread Adit Ranadive
On Sun, Sep 18, 2016 at 10:07:18 -0700, Leon Romanovsky wrote: > On Thu, Sep 15, 2016 at 10:36:12AM +0300, Yuval Shaia wrote: > > Hi Adit, > > Please see my comments inline. > > > > Besides that I have no more comment for this patch. > > > > Reviewed-by: Yuval Shaia > > >

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-18 Thread Leon Romanovsky
On Thu, Sep 15, 2016 at 10:36:12AM +0300, Yuval Shaia wrote: > Hi Adit, > Please see my comments inline. > > Besides that I have no more comment for this patch. > > Reviewed-by: Yuval Shaia > > Yuval > > On Thu, Sep 15, 2016 at 12:07:29AM +, Adit Ranadive wrote: > > On

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-15 Thread Yuval Shaia
Hi Adit, Please see my comments inline. Besides that I have no more comment for this patch. Reviewed-by: Yuval Shaia Yuval On Thu, Sep 15, 2016 at 12:07:29AM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 05:43:37 -0700, Yuval Shaia wrote: > > On Sun, Sep 11,

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-14 Thread Adit Ranadive
On Wed, Sep 14, 2016 at 05:43:37 -0700, Yuval Shaia wrote: > On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Ranadive wrote: > > + > > +static int pvrdma_poll_one(struct pvrdma_cq *cq, struct pvrdma_qp > **cur_qp, > > + struct ib_wc *wc) > > +{ > > + struct pvrdma_dev *dev =

Re: [PATCH v4 09/16] IB/pvrdma: Add support for Completion Queues

2016-09-14 Thread Yuval Shaia
On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Ranadive wrote: > + > +static int pvrdma_poll_one(struct pvrdma_cq *cq, struct pvrdma_qp **cur_qp, > +struct ib_wc *wc) > +{ > + struct pvrdma_dev *dev = to_vdev(cq->ibcq.device); > + int has_data; > + unsigned int