Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig
On Tue, Oct 11, 2016 at 11:40:42AM +0200, Maxime Ripard wrote: > On Mon, Oct 10, 2016 at 03:09:43PM +0200, Jean-Francois Moine wrote: > > On Mon, 10 Oct 2016 14:35:11 +0200 > > LABBE Corentin wrote: > > > > > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > > > > > > > Signed-off-by: Corentin Labbe > > > > > --- > > > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig > > > > > b/arch/arm/configs/multi_v7_defconfig > > > > > index 5845910..f44d633 100644 > > > > > --- a/arch/arm/configs/multi_v7_defconfig > > > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > > > > CONFIG_VIRTIO_NET=y > > > > > CONFIG_HIX5HD2_GMAC=y > > > > > CONFIG_SUN4I_EMAC=y > > > > > +CONFIG_SUN8I_EMAC=y > > > > > > > > Any reason to build it statically? > > > > > > No, just copied the same than CONFIG_SUN4I_EMAC that probably do > > > not need it also. > > > > All arm configs are done the same way, and, some day, the generic ARM > > V7 kernel will not be loadable in 1Gb RAM... > > Yeah, if possible, I'd really like to avoid introducing statically > built drivers to multi_v7. > I forgot to said it in my first answer, but yes I will change it. Regards
Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig
On Mon, Oct 10, 2016 at 03:09:43PM +0200, Jean-Francois Moine wrote: > On Mon, 10 Oct 2016 14:35:11 +0200 > LABBE Corentin wrote: > > > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > > > > > Signed-off-by: Corentin Labbe > > > > --- > > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig > > > > b/arch/arm/configs/multi_v7_defconfig > > > > index 5845910..f44d633 100644 > > > > --- a/arch/arm/configs/multi_v7_defconfig > > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > > > CONFIG_VIRTIO_NET=y > > > > CONFIG_HIX5HD2_GMAC=y > > > > CONFIG_SUN4I_EMAC=y > > > > +CONFIG_SUN8I_EMAC=y > > > > > > Any reason to build it statically? > > > > No, just copied the same than CONFIG_SUN4I_EMAC that probably do > > not need it also. > > All arm configs are done the same way, and, some day, the generic ARM > V7 kernel will not be loadable in 1Gb RAM... Yeah, if possible, I'd really like to avoid introducing statically built drivers to multi_v7. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig
On Mon, 10 Oct 2016 14:35:11 +0200 LABBE Corentin wrote: > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > > > Signed-off-by: Corentin Labbe > > > --- > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig > > > b/arch/arm/configs/multi_v7_defconfig > > > index 5845910..f44d633 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > > CONFIG_VIRTIO_NET=y > > > CONFIG_HIX5HD2_GMAC=y > > > CONFIG_SUN4I_EMAC=y > > > +CONFIG_SUN8I_EMAC=y > > > > Any reason to build it statically? > > > > No, just copied the same than CONFIG_SUN4I_EMAC that probably do not need it > also. All arm configs are done the same way, and, some day, the generic ARM V7 kernel will not be loadable in 1Gb RAM... -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig
On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/configs/multi_v7_defconfig > > b/arch/arm/configs/multi_v7_defconfig > > index 5845910..f44d633 100644 > > --- a/arch/arm/configs/multi_v7_defconfig > > +++ b/arch/arm/configs/multi_v7_defconfig > > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > > CONFIG_VIRTIO_NET=y > > CONFIG_HIX5HD2_GMAC=y > > CONFIG_SUN4I_EMAC=y > > +CONFIG_SUN8I_EMAC=y > > Any reason to build it statically? > No, just copied the same than CONFIG_SUN4I_EMAC that probably do not need it also. Regards Corentin Labbe
Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig
On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > Enable the sun8i-emac driver in the multi_v7 default configuration > > Signed-off-by: Corentin Labbe > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig > b/arch/arm/configs/multi_v7_defconfig > index 5845910..f44d633 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -229,6 +229,7 @@ CONFIG_NETDEVICES=y > CONFIG_VIRTIO_NET=y > CONFIG_HIX5HD2_GMAC=y > CONFIG_SUN4I_EMAC=y > +CONFIG_SUN8I_EMAC=y Any reason to build it statically? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
