Re: [PATCH v4 net-next 0/4] bpftool: cgroup bpf operations

[Daniel Borkmann]

On 12/13/2017 04:18 PM, Roman Gushchin wrote:
> This patchset adds basic cgroup bpf operations to bpftool.
> 
> Right now there is no convenient way to perform these operations.
> The /samples/bpf/load_sock_ops.c implements attach/detacg operations,
> but only for BPF_CGROUP_SOCK_OPS programs. Bps (part of bcc) implements
> bpf introspection, but lacks any cgroup-related specific.
> 
> I find having a tool to perform these basic operations in the kernel tree
> very useful, as it can be used in the corresponding bpf documentation
> without creating additional dependencies. And bpftool seems to be
> a right tool to extend with such functionality.
> 
> v4:
>   - ATTACH_FLAGS and ATTACH_TYPE are listed and described in docs and usage
>   - ATTACH_FLAG names converted to "multi" and "override"
>   - do_attach() recognizes ATTACH_FLAG abbreviations, e.g "mul"
>   - Local variables sorted ("reverse Christmas tree")
>   - unknown attach flags value will be never truncated

Series applied to bpf-next, thanks everyone!

Re: [PATCH v4 net-next 0/4] bpftool: cgroup bpf operations

[Quentin Monnet]

2017-12-13 15:18 UTC+ ~ Roman Gushchin 
> This patchset adds basic cgroup bpf operations to bpftool.
> 
> Right now there is no convenient way to perform these operations.
> The /samples/bpf/load_sock_ops.c implements attach/detacg operations,
> but only for BPF_CGROUP_SOCK_OPS programs. Bps (part of bcc) implements
> bpf introspection, but lacks any cgroup-related specific.
> 
> I find having a tool to perform these basic operations in the kernel tree
> very useful, as it can be used in the corresponding bpf documentation
> without creating additional dependencies. And bpftool seems to be
> a right tool to extend with such functionality.

Thank you Roman for this series, and for documenting the new commands
and flags!

Reviewed-by: Quentin Monnet