Re: [for-next 09/14] {net,IB}/mlx5: Add has_tag to mlx5_flow_act

2018-03-06 Thread Saeed Mahameed
On Mon, 2018-03-05 at 14:07 -0700, Jason Gunthorpe wrote: > On Mon, Mar 05, 2018 at 12:46:32PM -0800, Saeed Mahameed wrote: > > From: Matan Barak > > > > The has_tag member will indicate whether a tag action was specified > > in flow specification. > > It would be good to describe in the commit

Re: [for-next 09/14] {net,IB}/mlx5: Add has_tag to mlx5_flow_act

2018-03-05 Thread Jason Gunthorpe
On Mon, Mar 05, 2018 at 12:46:32PM -0800, Saeed Mahameed wrote: > From: Matan Barak > > The has_tag member will indicate whether a tag action was specified > in flow specification. It would be good to describe in the commit message why flow_act.flow_tag != MLX5_FS_DEFAULT_FLOW_TAG isn't good