Re: [net-next PATCH] mlx4: add missed recycle opportunity for XDP_TX on TX failure

2016-09-19 Thread Jesper Dangaard Brouer
On Mon, 19 Sep 2016 07:28:35 -0700 Eric Dumazet wrote: > > + xdp_drop: > > A label should start at the beginning of the line (ie : not indented) Understood, send a V2 -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at

Re: [net-next PATCH] mlx4: add missed recycle opportunity for XDP_TX on TX failure

2016-09-19 Thread Eric Dumazet
On Mon, 2016-09-19 at 09:40 +0200, Jesper Dangaard Brouer wrote: > Correct drop handling for XDP_TX on TX failure, were recently added in > commit 95357907ae73 ("mlx4: fix XDP_TX is acting like XDP_PASS on TX > ring full"). > > The change missed an opportunity for recycling the RX page, instead

Re: [net-next PATCH] mlx4: add missed recycle opportunity for XDP_TX on TX failure

2016-09-19 Thread Tariq Toukan
On 19/09/2016 10:40 AM, Jesper Dangaard Brouer wrote: Correct drop handling for XDP_TX on TX failure, were recently added in commit 95357907ae73 ("mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full"). The change missed an opportunity for recycling the RX page, instead of going through